414274 - Cancelling quit request whilst downloading extension will result in no warning if user tries to quit again

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Graeme McCutcheon [:graememcc]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

When downloading a large extension, attempt to quit, and then cancel the quit request.

The extension manager will state that the extension is not compatible with your version of Firefox, regardless of the extension's actual compatibility. It will also give no feedback that the extension is, in fact, still downloading.

In addition, unless the user starts another extension download, extension manager will not issue any more quit warnings.

Reproducible: Always

Steps to Reproduce:
1. On a clean profile, start downloading a large extension (eg all peers)
2. When it opens, quickly close the extension manager, and then attempt to quit Firefox
3. When the quit warning about cancelling downloads appears, click Cancel
4. Re-open extension manager.
5. Wait a reasonable amount of time (long enough for the extension download to finish).
6. Restart Firefox. Find that the extension was still downloading, was compatible, and has been installed.
Actual Results:  
On reopening extension manager,the extension is now noted as being incompatible with your version of FF.

Expected Results:  
On reopening extension manager, you continue to see the progress of the extension download.

Comment 1

[Graeme McCutcheon [:graememcc]]

Meh, I'm a bit of an idiot.

Ignore anything above about the download progress not being reported. Totally failed to notice that if you reopen add-on manager, it will always be on the Extensions tab (download progress is reported in the installation tab, and is in fact, unaffected).

Additionally, the extension is always reported as incompatible until it is fully downloaded. Following the steps to reproduce above does not in any way influence this. (FWIW, I still think that that isn't great behaviour.)

However, I stand by the fact that cancelling a quit request (in any of the dialogs that can throw it up - ie extension mgr, download mgr, or multiple tabs) will result in extension manager never warning the user again that a download is  in progress, unless another extension download is started.

Revised STR:
1. On a clean profile, start downloading a large extension (eg all peers)
2. When it opens, quickly close the add-ons window, and then attempt to quit
Firefox
3. When the quit warning about cancelling downloads appears, click Cancel
4. Re-open the add-ons window.
5. Click on installation tab. Verify extension is still downloading.
6. Close add-ons. Attempt to quit browser.

Actual Results:  
Browser quits without warning.

Expected Results:  
As per step 3, a warning should be issued that an extension download is in progress.

Comment 2

[Graeme McCutcheon [:graememcc]]

I know this is an edge-case as a fair number of extensions are so small that most users will not hit this, but nominating blocking on the basis that incorrectly suppressing user warnings is plain wrong.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This does not block the final release of Firefox 3.

Comment 5

[[:Aleksej]]

Confirmed Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b4pre) Gecko/2008021204 Minefield/3.0b4pre with StR from comment #1.

Comment 6

[Andy McKay]

Due to a long period of inactivity on this bug (6.98 years), I am intending to close this bug within a month or so in accordance with: https://wiki.mozilla.org/Add-ons/OldBugs Please remove [intent-to-close] from the whiteboard and comment on this bug if you would like to keep it open.