414292 - [Oracle] Change query in table series back to MEDIUMTEXT

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Xiaoou]

Oracle LOB can not be used in group by, and we change it from LONGTEXT back to
MEDIUMTEXT.

Add get_alter_column_ddl, _get_alter_type_sql, get_rename_column_ddl to Oracle.

Comment 1

[Xiaoou]

Attachment: v1

Comment 2

[Frédéric Buclin]

How long before checksetup.pl completely messes up the DB with all these changes being undone?

Comment 3

[Max Kanat-Alexander]

Comment on attachment 299659 [details] [diff] [review]
v1

  Let's split this into two different bugs. One for switching the column back to MEDIUMTEXT, and another that enables ALTER COLUMN for Oracle.

>+    # 2008-01-18 [e-mail] - Bug 414292
>+    $dbh->bz_alter_column('series', 'query',
>+        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 });
>+
> [snip]
>-    return if $dbh->bz_column_info('series', 'query')->{TYPE} eq 'LONGTEXT';
>+    return if 
>+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';

  Apparently, you are not thinking, here, about what happens when people run checksetup.pl twice, which they do all the time.

Comment 4

[Xiaoou]

> >+    # 2008-01-18 [e-mail] - Bug 414292
> >+    $dbh->bz_alter_column('series', 'query',
> >+        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 });
This will do all the time, it changes series.query to MEDIUMTEXT.
> >+    return if 
> >+        $dbh->bz_column_info('namedqueries', 'query')->{TYPE} eq 'LONGTEXT';
>   Apparently, you are not thinking, here, about what happens when people run
> checksetup.pl twice, which they do all the time.

If people run checksetup.pl again, it will return directly because namedqueries.query is already LONGTEXT and types had been changed, and the following alter-table steps are not needed to do. 

Comment 5

[Max Kanat-Alexander]

Did you try actually running it twice on a real database?

Comment 6

[Xiaoou]

What will happen when running checksetup.pl again? it always passed on my side and nothing changed.

Comment 7

[Max Kanat-Alexander]

Comment on attachment 299659 [details] [diff] [review]
v1

Okay, so apparently I should review this again.

Comment 8

[Max Kanat-Alexander]

Comment on attachment 299659 [details] [diff] [review]
v1

Okay, this is fine, but the DB::Schema::Oracle part is not a part of this patch and I won't be checking it in with this patch.

Comment 9

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.99; previous revision: 1.98
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.51; previous revision: 1.50
done

Comment 10

[Frédéric Buclin]

Comment on attachment 299659 [details] [diff] [review]
v1

>     # 2007-11-29 [e-mail] - Bug 153129
>     _change_text_types();
> 
>+    # 2008-01-18 [e-mail] - Bug 414292
>+    $dbh->bz_alter_column('series', 'query',
>+        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 });
>+
>     # 2007-09-09 [e-mail] - Bug 99215
>     _fix_attachment_modification_date();

Why are dates out of order?

Comment 11

[Max Kanat-Alexander]

(In reply to comment #10)
> Why are dates out of order?

  I fixed that on checkin.