414306 - exthandler should set STATE_IS_(REQUEST|NETWORK) to conform with nsIWebProgressListener

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Ed Lee :Mardak]

exthandler right now only sends a STATE_START and STATE_STOP by itself. According to the nsIWebProgressListener interface, REQUEST should be set for requests and NETWORK for a the "nsIWebProgress group". We don't really have a nsIWebProgress here..

<bz> since it's faking a loadgroup for the whole thing
<bz> like I said earlier, without an nsIWebProgress the whole thing is sorta underdefined...

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Set the additional flags. :( indenting

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 299688 [details] [diff] [review]
v1

Sure

Comment 3

[Ed Lee :Mardak]

Comment on attachment 299688 [details] [diff] [review]
v1

Conform! ;)

Comment 4

[Ed Lee :Mardak]

Landed as part of the fix for bug 405107.

Shawn: In addition to the "save page as" potential testcase, it would be neat if we could simulate dialog actions to save "open with" downloads.

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.362; previous revision: 1.361
done