Closed Bug 414325 Opened 12 years ago Closed 12 years ago

Use DownloadUtils for extension/theme manager downloads

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: Mardak, Assigned: mossop)

Details

(Keywords: late-l10n)

Attachments

(1 file, 1 obsolete file)

With bug 394516 fixed, there's a DownloadsUtils javascript module that knows how to display download progress for size and time and other fun stuff.

http://mxr.mozilla.org/seamonkey/source/toolkit/mozapps/downloads/src/DownloadUtils.jsm#39
Attached patch patch rev 1 (obsolete) — Splinter Review
Good reusable code, lets us drop some of our code and strings.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #299786 - Flags: review?(robert.bugzilla)
Whiteboard: [has patch]
I believe _replaceInsert was only used by _formatKBytes, so up to you if you want to keep it around if something in the future might want it.
Attached patch patch rev 2Splinter Review
Yeah well spotted, I don't think we need that anymore.
Attachment #299786 - Attachment is obsolete: true
Attachment #299800 - Flags: review?(robert.bugzilla)
Attachment #299786 - Flags: review?(robert.bugzilla)
Comment on attachment 299800 [details] [diff] [review]
patch rev 2

Nice!
Attachment #299800 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 299800 [details] [diff] [review]
patch rev 2

This is a code saving, switching to shared code for this.
Attachment #299800 - Flags: approval1.9?
Comment on attachment 299800 [details] [diff] [review]
patch rev 2

a1.9+=damons
Attachment #299800 - Flags: approval1.9? → approval1.9+
Checking in toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties,v  <--  extensions.properties
new revision: 1.49; previous revision: 1.48
done
Checking in toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <--  extensions.js
new revision: 1.158; previous revision: 1.157
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: late-l10n
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 3 beta3
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.