Closed Bug 414368 Opened 17 years ago Closed 16 years ago

The find bar close button is 1px too high

Categories

(Toolkit :: Find Toolbar, defect)

Product:
Toolkit
Component:
Find Toolbar
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1a1

People

(Reporter: u88484, Assigned: kliu)

References

Details

(Keywords: polish)

Attachments

(2 files, 2 obsolete files)

Better screenshot and includes both states
9.85 KB, image/png
Details
fix
905 bytes, patch
Gavin
: review+
mtschrep
: approval1.9-
samuel.sidler+old
: approval1.9.0.4-
Details | Diff | Splinter Review
Attached image Screenshot (obsolete) — 
The findbar close button is 1px too high.  The button is 5 pixels from the top of the toolbar and 7 pixels from the bottom of the toolbar.  The icon should be moved down, 1 pixel so it is centered in the toolbar with 6 pixels on the top and bottom of the icon from the toolbar borders.
Attached image Screenshot (obsolete) — 

        Attachment #299757 -
        Attachment is obsolete: true

    
  
Summary: Close button is 1px too high → The find bar close button is 1px too high

    
    

    
  


  

        Attachment #299758 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix
        — 
          — Splinter Review
      

    


  
The close button has an even height, and so does the find toolbar.  So the close button *should* be centering correctly on the toolbar.  So why isn't it?  The close button was given a set of asymmetric vertical paddings: 3px on top, 4px on the bottom, which is why it's failing to center correctly.  The close buttons on the notification bar and side bar had been given symmetric vertical margins, so let's do the same for the find toolbar.
Assignee: nobody → kliu
Status: NEW → ASSIGNED

        Attachment #320226 -
        Flags: review?(gavin.sharp)

        Attachment #320226 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
Comment on attachment 320226 [details] [diff] [review]
fix

no-risk patch to fix a minor alignment glitch

        Attachment #320226 -
        Flags: approval1.9?

    
  
Blocks: 425582
Severity: normal → trivial

    
    

    
  
Comment on attachment 320226 [details] [diff] [review]
fix

we are closed down for showstoppers. We can get this in 3.0.1 if needed.

        Attachment #320226 -
        Flags: approval1.9? → approval1.9-

    
  
Flags: wanted1.9.0.x?

    
  
Keywords: checkin-needed

    
    

    
  
5fb7261b7e36
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1

    
  

        Attachment #320226 -
        Flags: approval1.9.0.1?

        Attachment #320226 -
        Flags: approval1.9.0.1? → approval1.9.0.2?

    
  
Target Milestone: Firefox 3.1 → Firefox 3.1a1
Product: Firefox → Toolkit

    
    

    
  
Comment on attachment 320226 [details] [diff] [review]
fix

Pushing approval out to 1.9.0.3.

        Attachment #320226 -
        Flags: approval1.9.0.2? → approval1.9.0.3?

    
    

    
  
Doesn't really meet the "wanted" criteria (security, stability, regression from maintenance release) for 1.9.0.x. And likewise, doesn't meet the criteria for 1.9.0.4.
Flags: wanted1.9.0.x? → wanted1.9.0.x-

        Attachment #320226 -
        Flags: approval1.9.0.4? → approval1.9.0.4-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: