414461 - Delay importing of PluralForm and DownloadUtils for statusbar

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

This might be the cause of Ts issues because both modules import some strings.

Comment 1

[Shawn Wilsher :sdwilsh]

I thought they weren't loaded until they were needed?

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Comment 3

[Ed Lee :Mardak]

(In reply to comment #1)
> I thought they weren't loaded until they were needed?
DownloadUtils initializes gStr at load time.

I suppose potentially we could delay load.. something like instead of..

let gStr = { strings we want };
/* loadStringsFromBundle(); */
let DownloadUtils = {
  foo: function() gStr.stringIWant
};

We create a new private object (so that we don't pollute DownloadUtils object) with a member variable that loads stuff on first use..

let _ = {
  get str() {
    delete this.str;
    let strings = { strings we want };
    /* loadStringsFromBundle(); */
    return this.str = strings;
  }
};
let DownloadUtils = {
  foo: function() _.str.stringIWant
};

Comment 4

[Shawn Wilsher :sdwilsh]

you could also just make gStr an object that builds the strings as needed, right?

Comment 5

[Ed Lee :Mardak]

Right, but that would require programatically creating getters on the gStr object.

gStr.__defineGetter("paused", function() { delete gStr.paused; strbundleblahblah; return gStr.paused = realstring; });

So we would need to iterate over each string and create a getter. There's also the overhead of getting the string bundle. I'll try something...

Comment 6

[Shawn Wilsher :sdwilsh]

what about:
gStr = {
 get paused() {
  delete this.paused;
  ...
  this.paused = realstring;
  }
};

Comment 7

[Ed Lee :Mardak]

Too much duplicate code :p you have that whole code block copy/pasted to each. Don't worry! I've got something ;)

Comment 8

[Asaf Romano (gone)]

Comment on attachment 299862 [details] [diff] [review]
v1

I think we should fix gStr not to init itself in the global scope anyway.

r=mano though.

Comment 9

[Ed Lee :Mardak]

Comment on attachment 299862 [details] [diff] [review]
v1

Hopefully this will help reduce Ts.

Comment 10

[Ed Lee :Mardak]

(In reply to comment #8)
> (From update of attachment 299862 [details] [diff] [review])
> I think we should fix gStr not to init itself in the global scope anyway.
Filed bug 414486.

Comment 11

[Damon Sicore (:damons)]

Comment on attachment 299862 [details] [diff] [review]
v1

a1.9+=damons

Comment 12

[Ed Lee :Mardak]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.945; previous revision: 1.944
done