414479 - buildbot 0.7.6 fixes/enhancements

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

There is at least one fix upstream that we need to pick up for 0.7.6. There may be other fixes/enhancements that we want. I'm going to batch them together in this bug (separate patches, though).

Comment 1

[[e-mail] (:bhearsum)]

I'm not sure what the proper procedure is here; these patches have been approved and checked into the upstream Buildbot tree. Do they still need review? I'm going to attach them without requesting review for now.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: [checked in] Fix Waterfall links from MailNotifier

Taken from http://buildbot.net/trac/ticket/112. This patch has already been approved an checked in there.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix ShellCommand env arguments w/ factory.addStep() format

From http://buildbot.net/trac/ticket/126.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix tracebacks that occur when SlaveLock is used

I've encountered this when using 'Force Build'.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix Mercurial checkouts, obey version

From http://buildbot.net/trac/ticket/103 and http://buildbot.net/trac/ticket/122

Comment 6

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix log following on OS X

Comment 7

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix builder corruption when the buildmaster is shut down with a waiting slavelock

Comment 8

[[e-mail] (:bhearsum)]

(In reply to comment #4)
> Created an attachment (id=299999) [details]
> fix tracebacks that occur when SlaveLock is used
> 
> I've encountered this when using 'Force Build'.
> 

http://buildbot.net/trac/ticket/111


(In reply to comment #6)
> Created an attachment (id=300002) [details]
> fix log following on OS X
> 

http://buildbot.net/trac/ticket/141


(In reply to comment #7)
> Created an attachment (id=300003) [details]
> fix builder corruption when the buildmaster is shut down with a waiting
> slavelock
> 

http://buildbot.net/trac/ticket/118

Comment 9

[[e-mail] (:bhearsum)]

Attachment: [checked in] 'stop build' is missing from 0.7.6 waterfall

http://buildbot.net/trac/ticket/114

Comment 10

[[e-mail] (:bhearsum)]

Attachment: [checked in] fix hanging fileupload/filedownload steps

http://buildbot.net/trac/ticket/106

Comment 11

[[e-mail] (:bhearsum)]

Attachment: [checked in] support twisted 2.5 as well as older versions

http://buildbot.net/trac/ticket/53

Comment 12

[[e-mail] (:bhearsum)]

I've applied all of these patches cleanly to the BUILDBOT_0_7_6_BRANCH. I've also run the unit tests:
PASSED (skips=23, successes=269)

Comment 13

[Robert Helmer [:rhelmer]]

r=rhelmer to land in BUILDBOT_0_7_6_BRANCH

Comment 14

[[e-mail] (:bhearsum)]

Comment on attachment 300007 [details] [diff] [review]
[checked in] support twisted 2.5 as well as older versions

Checking in buildbot/scripts/startup.py;
/cvsroot/mozilla/tools/buildbot/buildbot/scripts/startup.py,v  <--  startup.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 15

[[e-mail] (:bhearsum)]

Comment on attachment 300006 [details] [diff] [review]
[checked in] fix hanging fileupload/filedownload steps

Checking in buildbot/slave/commands.py;
/cvsroot/mozilla/tools/buildbot/buildbot/slave/commands.py,v  <--  commands.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done
Checking in buildbot/test/runutils.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/runutils.py,v  <--  runutils.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done
Checking in buildbot/test/test_transfer.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/test_transfer.py,v  <--  test_transfer.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 300004 [details] [diff] [review]
[checked in] 'stop build' is missing from 0.7.6 waterfall

Checking in buildbot/status/web/build.py;
/cvsroot/mozilla/tools/buildbot/buildbot/status/web/build.py,v  <--  build.py
new revision: 1.1.1.1.2.1; previous revision: 1.1.1.1
done
Checking in buildbot/test/test_webparts.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/test_webparts.py,v  <--  test_webparts.py
new revision: 1.1.1.1.2.1; previous revision: 1.1.1.1
done

Comment 17

[[e-mail] (:bhearsum)]

Comment on attachment 300003 [details] [diff] [review]
[checked in] fix builder corruption when the buildmaster is shut down with a waiting slavelock

Checking in buildbot/status/web/base.py;
/cvsroot/mozilla/tools/buildbot/buildbot/status/web/base.py,v  <--  base.py
new revision: 1.1.1.1.2.1; previous revision: 1.1.1.1
done

Comment 18

[[e-mail] (:bhearsum)]

Comment on attachment 300002 [details] [diff] [review]
[checked in] fix log following on OS X

Checking in buildbot/scripts/logwatcher.py;
/cvsroot/mozilla/tools/buildbot/buildbot/scripts/logwatcher.py,v  <--  logwatcher.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 19

[[e-mail] (:bhearsum)]

Comment on attachment 300001 [details] [diff] [review]
[checked in] fix Mercurial checkouts, obey version

Checking in buildbot/slave/commands.py;
/cvsroot/mozilla/tools/buildbot/buildbot/slave/commands.py,v  <--  commands.py
new revision: 1.1.1.2.2.2; previous revision: 1.1.1.2.2.1
done
Checking in buildbot/test/test_vc.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/test_vc.py,v  <--  test_vc.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 20

[[e-mail] (:bhearsum)]

Comment on attachment 299999 [details] [diff] [review]
[checked in] fix tracebacks that occur when SlaveLock is used

Checking in buildbot/slave/commands.py;
/cvsroot/mozilla/tools/buildbot/buildbot/slave/commands.py,v  <--  commands.py
new revision: 1.1.1.2.2.2; previous revision: 1.1.1.2.2.1
done
Checking in buildbot/test/test_vc.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/test_vc.py,v  <--  test_vc.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 21

[[e-mail] (:bhearsum)]

Comment on attachment 299997 [details] [diff] [review]
[checked in] fix ShellCommand env arguments w/ factory.addStep() format

Checking in buildbot/steps/shell.py;
/cvsroot/mozilla/tools/buildbot/buildbot/steps/shell.py,v  <--  shell.py
new revision: 1.2.2.1; previous revision: 1.2
done
Checking in buildbot/test/test_steps.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/test_steps.py,v  <--  test_steps.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 22

[[e-mail] (:bhearsum)]

Comment on attachment 299996 [details] [diff] [review]
[checked in] Fix Waterfall links from MailNotifier

Checking in buildbot/status/builder.py;
/cvsroot/mozilla/tools/buildbot/buildbot/status/builder.py,v  <--  builder.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done
Checking in buildbot/test/test_web.py;
/cvsroot/mozilla/tools/buildbot/buildbot/test/test_web.py,v  <--  test_web.py
new revision: 1.1.1.2.2.1; previous revision: 1.1.1.2
done

Comment 23

[[e-mail] (:bhearsum)]

I just checked out the new BUILDBOT_0_7_6_BRANCH and confirmed that all of the unit tests still pass:
PASSED (skips=23, successes=269)