Closed Bug 414481 Opened 14 years ago Closed 14 years ago

Get Add-ons Tab: make EULA text selectable

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta5

People

(Reporter: madhava, Assigned: mossop)

References

Details

Attachments

(1 file)

Sometimes an add-on with a EULA will have just a URL for it's EULA text, in which case it's frustrating to have to retype it.  This isn't really great behavior from the add-on (better would be to have the full text included), so I'd lean away from creating links automatically.  In other cases, users may want to copy EULA text to keep it.
Afaik, we ask the developers to add their complete EULA to the add-on details, so this shouldn't happen (and we should fix it). Can we run a query, searching for short EULAs containing "http"?
(In reply to comment #1)
> Afaik, we ask the developers to add their complete EULA to the add-on details,
> so this shouldn't happen (and we should fix it). Can we run a query, searching
> for short EULAs containing "http"?

Probably best file that as an AMO issue, I'd look for EULA's that start with http: or are just short (some are just "GPL")
Blocks: 404024
Assignee: nobody → dtownsend
Attached patch patch rev 1Splinter Review
Changes the display to a readonly textbox and tweaks styles accordingly.
Attachment #302588 - Flags: review?(robert.bugzilla)
Status: NEW → ASSIGNED
Whiteboard: [has patch]
Comment on attachment 302588 [details] [diff] [review]
patch rev 1

r=me - I'm assuming you verified that the style changes are standard throughout the app.
Attachment #302588 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 302588 [details] [diff] [review]
patch rev 1

Yes, matched up.

Requesting approval on this simple fix requested by UX.
Attachment #302588 - Flags: approval1.9?
Comment on attachment 302588 [details] [diff] [review]
patch rev 1

a1.9=beltzner
Attachment #302588 - Flags: approval1.9? → approval1.9+
Checking in toolkit/mozapps/extensions/content/eula.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/eula.js,v  <--  eula.js
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/mozapps/extensions/content/eula.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/eula.xul,v  <--  eula.xul
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/eula.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/eula.css,v  <--  eula.css
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/winstripe/mozapps/extensions/eula.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/eula.css,v  <--  eula.css
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → Firefox 3 beta5
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.