414481 - Get Add-ons Tab: make EULA text selectable

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Madhava Enros [:madhava]]

Sometimes an add-on with a EULA will have just a URL for it's EULA text, in which case it's frustrating to have to retype it.  This isn't really great behavior from the add-on (better would be to have the full text included), so I'd lean away from creating links automatically.  In other cases, users may want to copy EULA text to keep it.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Afaik, we ask the developers to add their complete EULA to the add-on details, so this shouldn't happen (and we should fix it). Can we run a query, searching for short EULAs containing "http"?

Comment 2

[Dave Townsend [:mossop]]

(In reply to comment #1)
> Afaik, we ask the developers to add their complete EULA to the add-on details,
> so this shouldn't happen (and we should fix it). Can we run a query, searching
> for short EULAs containing "http"?

Probably best file that as an AMO issue, I'd look for EULA's that start with http: or are just short (some are just "GPL")

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Changes the display to a readonly textbox and tweaks styles accordingly.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 302588 [details] [diff] [review]
patch rev 1

r=me - I'm assuming you verified that the style changes are standard throughout the app.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 302588 [details] [diff] [review]
patch rev 1

Yes, matched up.

Requesting approval on this simple fix requested by UX.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 302588 [details] [diff] [review]
patch rev 1

a1.9=beltzner

Comment 7

[Dave Townsend [:mossop]]

Checking in toolkit/mozapps/extensions/content/eula.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/eula.js,v  <--  eula.js
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/mozapps/extensions/content/eula.xul;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/eula.xul,v  <--  eula.xul
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/eula.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/eula.css,v  <--  eula.css
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/winstripe/mozapps/extensions/eula.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/eula.css,v  <--  eula.css
new revision: 1.2; previous revision: 1.1
done