414486 - Lazily load stringbundle and lazily load strings for DownloadUtils

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Whoever imports DownloadUtils will be taking a hit because we eagerly load the string bundle and strings at import. We can delay this until they're actually used.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Yay mochi unit tests.

Create getters that lazily loads strings from a lazily-loaded stringbundle.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 299913 [details] [diff] [review]
v1

This needs some tests (as discussed on irc).  They should be xpcshell tests living in toolkit/mozapps/downloads/tests/unit/

Comment 3

[Ed Lee :Mardak]

Attachment: v2

Now with more testcase! :) Works before and after the laziness.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 299978 [details] [diff] [review]
v2

r=sdwilsh

Comment 5

[Mike Schroepfer]

Comment on attachment 299978 [details] [diff] [review]
v2

Mmm more testcases

Comment 6

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/src/DownloadUtils.jsm;
/cvsroot/mozilla/toolkit/mozapps/downloads/src/DownloadUtils.jsm,v  <--  DownloadUtils.jsm
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/mozapps/downloads/tests/Makefile.in;
/cvsroot/mozilla/toolkit/mozapps/downloads/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/downloads/tests/unit/test_DownloadUtils.js,v
done
Checking in toolkit/mozapps/downloads/tests/unit/test_DownloadUtils.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/tests/unit/test_DownloadUtils.js,v  <--  test_DownloadUtils.js
initial revision: 1.1
done