414525 - Manage identities window does not resize correctly.

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Peter Urbanec]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071220 Firefox/2.0.0.11
Build Identifier: Mozilla Thunderbird 2.0.0.9

When resizing the window, the layout engine does not grow the list view, instead it pads the vertical area with blank space.


Reproducible: Always

Steps to Reproduce:
1. Click the "Manage Identities..." button in account preferences.

2. The resulting window has a list of four identities.

3. Resize the window with the intent to show more entries in the list.

Actual Results:  
The list still only shows four entries, however there is a lot of blank space between the string "Multiple Identities Support" and the list view itself.


Expected Results:  
The list view should grow with the windows size to reveal more entries.

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008020103 Lightning/0.6a1 Thunderbird/3.0a1pre ID:2008020103

Comment 2

[Peter Urbanec]

This is still a problem with Thunderbird 3.1.2

> Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100828 Thunderbird/3.1.2

Surely changing the layout to allow resizing of the list view can't be so hard that it takes more than two years to fix. ;-)

Comment 3

[Peter Urbanec]

Attachment: Patch to fix resizing of identities list.

Indeed, the fix is very simple. Just move the flex attribute from the label to the hbox that contains the list view.

Comment 4

[Ludovic Hirlimann [:Usul]]

(In reply to comment #3)
> Created attachment 470813 [details] [diff] [review]
> Patch to fix resizing of identities list.
> 
> Indeed, the fix is very simple. Just move the flex attribute from the label to
> the hbox that contains the list view.

If you want your code to get in it needs to be reviewed as per https://developer.mozilla.org/en/Mailnews_and_Mail_code_review_requirements I've just set somereviews. Blake feel free to change to a better suited reviewer. I'ave also aske andreasn for ui-review. Ain't sure if it's required.

We usually need some unit test, but I'm not sure it's relevant here, the reviewer should tell.

Comment 5

[Peter Urbanec]

Attachment: Patch to fix resizing of identities list. (Updated with correct path to the source file)

Same patch as before, just updated the pathname to the source file, since my patch was based on the path in the JAR file, rather than the path used in the Mercurial repository.

I'm not familiar with Mozilla development practices and don't really have the time to get heavily involved. I'm submitting what seems like a trivial patch to an old cosmetic bug in the hope that constructive feedback will be of more value that repeated comments to the tune of "fix it please!"

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 471116 [details] [diff] [review]
Patch to fix resizing of identities list. (Updated with correct path to the source file)

This looks great, the dialog behaves much better now!
Thanks for your patch!

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 471116 [details] [diff] [review]
Patch to fix resizing of identities list. (Updated with correct path to the source file)

Sorry this took me so long to review, but I had to update my Ubuntu Virtual Machine.  Anyways, the patch makes sense to me, and I like it.

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/cb0299a5d187

Thanks Peter.

Comment 9

[Nikolay Shopik]

Mark, you set target milestone Thunderbird 3.3a1, when we don't even release 3.2a1 yet I'm missing something or we already building 3.3a1pre builds?

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to comment #9)
> Mark, you set target milestone Thunderbird 3.3a1, when we don't even release
> 3.2a1 yet I'm missing something or we already building 3.3a1pre builds?

That's own trunk is coming to be renamed at some point. The numbering will come.