414564 - AMO Integration: Rating star icons need some love

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[u88484]

Attachment: Screenshot

In the new AMO integrated panel, the rating star icons need some love.  When an extension/theme is selected, a white outline appears around the star and the stars also look disfigured.  See screenshot.

Comment 1

[u88484]

Attachment: Screenshot 2, shows other states

Comment 2

[Alfred Kayser]

Attachment: This is what I made for my themes, it also supports the full range of ratings (0-10)

The 'code' to use my ratings image:

.addonRating[rating]{
  display:-moz-box;
  width:68px;
  height:12px;
  list-style-image:url(chrome://mozapps/skin/extensions/ratings.png)}

.addonRating[rating="0"]{-moz-image-region:rect(0 68px 12px 0)}
.addonRating[rating="1"]{-moz-image-region:rect(12px 68px 24px 0)}
.addonRating[rating="2"]{-moz-image-region:rect(24px 68px 36px 0)}
.addonRating[rating="3"]{-moz-image-region:rect(36px 68px 48px 0)}
.addonRating[rating="4"]{-moz-image-region:rect(48px 68px 60px 0)}
.addonRating[rating="5"]{-moz-image-region:rect(60px 68px 72px 0)}
.addonRating[rating="6"]{-moz-image-region:rect(72px 68px 84px 0)}
.addonRating[rating="7"]{-moz-image-region:rect(84px 68px 96px 0)}
.addonRating[rating="8"]{-moz-image-region:rect(96px 68px 108px 0)}
.addonRating[rating="9"]{-moz-image-region:rect(108px 68px 120px 0)}
.addonRating[rating="10"]{-moz-image-region:rect(120px 68px 132px 0)}

This supports the full rating scale, whereas the current version rounds down to whole stars...

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Created an attachment (id=300924) [details]
> This is what I made for my themes, it also supports the full range of ratings
> (0-10)

Looks great to me! Just to confirm, if you're offering these for us to use please request ui-review on the attachment from [e-mail]

Comment 4

[u88484]

Where are we even getting this rating from? I haven't seen any ratings or been able to rate an add-on on AMO in ages.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Added to the icon inventory, will be getting new icons for all platforms.

Comment 6

[Dave Townsend [:mossop]]

Just waiting on the OSX icons to close this.

Comment 7

[Dave Townsend [:mossop]]

These look pretty bad, want to make sure this isn't lost.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

>These look pretty bad, want to make sure this isn't lost.

yeah, not interacting well with the various selection colors.  We will need to refresh them in the next icon drop.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Should this be in Firefox::Theme? I'll let Mossop decide, but I think so.

Comment 10

[u88484]

Will these also match on amo or should that be spun off into another bug?

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

>Will these also match on amo or should that be spun off into another bug?

They will look different on each platform.  We may want have amo adapt a variety of icons like the stars, or the puzzle piece based on the user agent.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

We have the new icons from the IconFactory now, just a matter of slicing and dicing.

Comment 14

[Madhava Enros [:madhava]]

(In reply to comment #13)
> We have the new icons from the IconFactory now, just a matter of slicing and
> dicing.
> 

Even for OSX?

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

Stephen created the new icons for OS X, not sure when they are landing.

Comment 16

[Stephen Horlander [:shorlander]]

(In reply to comment #15)
> Stephen created the new icons for OS X, not sure when they are landing.
> 

Kevin and I are working on getting some stuff in before the the freeze. Since the icons are already finished we just need to update the CSS. They should make it in.

Comment 17

[Dave Townsend [:mossop]]

The new icons for OSX have landed and look awesome

Comment 18

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041404 Minefield/3.0pre.