Closed Bug 414575 Opened 14 years ago Closed 14 years ago

The initial size of the library window cannot be specified

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta4

People

(Reporter: alex, Assigned: mak)

Details

(Keywords: l12y, late-l10n)

Attachments

(3 files, 1 obsolete file)

Attached image Places dialog in Linux
The initial size of the places dialog cannot be specified in dtd or properties files by the localizers. For the romanian language, this is a problem on Linux, see the attachements for screenshots. The search box is cut off and the dialog needs to be manually resized to see the entire box.
In Windows there is no problem.
Trying to get some input here.

Michael, is there something in the linux theme that makes the places dialog more space critical? Apart from broken DPI settings that I hear about on #developers every other day.

Alex, Mike, is there a reason for having the default size of the places dialog be hardcoded pixels?
Keywords: l12y
Flags: blocking-firefox3?
>Alex, Mike, is there a reason for having the default size of the places dialog
>be hardcoded pixels?

No particular reason, I believe I suggested a default size awhile back which may have led to it being hardcoded.
Then we should fix that.
Keywords: late-l10n
Priority: -- → P1
beltzner, can you plus this one?
Flags: blocking-firefox3? → blocking-firefox3+
Summary: The initial size of the places dialog cannot be specified → The initial size of the library window cannot be specified
Assignee: nobody → sdwilsh
Whiteboard: [needs patch]
Target Milestone: --- → Firefox 3 beta4
Marco, this should be straightforward, need localizable height/width like we have for most/all other windows, and we need the fix by Thursday.
Assignee: sdwilsh → mak77
Status: NEW → ASSIGNED
taken
Attached patch patch (obsolete) — Splinter Review
this appear to be enough
Attachment #304197 - Flags: review?(dietrich)
Comment on attachment 304197 [details] [diff] [review]
patch

please keep height and width as separate attributes. r=me otherwise.
Attachment #304197 - Flags: review?(dietrich) → review+
Attached patch patchSplinter Review
as you will, bringing over your review
Attachment #304197 - Attachment is obsolete: true
Keywords: checkin-needed
OS: Linux → All
Hardware: PC → All
Whiteboard: [needs patch]
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--  places.dtd
new revision: 1.42; previous revision: 1.41
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.107; previous revision: 1.106
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.