414575 - The initial size of the library window cannot be specified

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Alexandru Szasz]

Attachment: Places dialog in Linux

The initial size of the places dialog cannot be specified in dtd or properties files by the localizers. For the romanian language, this is a problem on Linux, see the attachements for screenshots. The search box is cut off and the dialog needs to be manually resized to see the entire box.

Comment 1

[Alexandru Szasz]

Attachment: Places dialog in Windows

In Windows there is no problem.

Comment 2

[Axel Hecht [:Pike]]

Trying to get some input here.

Michael, is there something in the linux theme that makes the places dialog more space critical? Apart from broken DPI settings that I hear about on #developers every other day.

Alex, Mike, is there a reason for having the default size of the places dialog be hardcoded pixels?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Alex, Mike, is there a reason for having the default size of the places dialog
>be hardcoded pixels?

No particular reason, I believe I suggested a default size awhile back which may have led to it being hardcoded.

Comment 4

[Axel Hecht [:Pike]]

Then we should fix that.

Comment 5

[chris hofmann]

beltzner, can you plus this one?

Comment 6

[Mike Connor [:mconnor]]

Marco, this should be straightforward, need localizable height/width like we have for most/all other windows, and we need the fix by Thursday.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

taken

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

this appear to be enough

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 304197 [details] [diff] [review]
patch

please keep height and width as separate attributes. r=me otherwise.

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

as you will, bringing over your review

Comment 11

[Reed Loden [:reed]]

Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--  places.dtd
new revision: 1.42; previous revision: 1.41
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.107; previous revision: 1.106
done

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv