Closed Bug 414590 Opened 17 years ago Closed 17 years ago

Move [mode="text"] toolbarbutton label styles to browser.css

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 3 beta3

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file)

toolkit/themes/pinstripe/global/toolbar.css:

toolbar[mode="text"] .toolbarbutton-1 > .toolbarbutton-text, toolbar[mode="text"] .toolbarbutton-1 > stack > toolbarbutton > .toolbarbutton-text {
  margin: 4px;
}

Those rules are pretty ancient and it seems that only the first one is actually applied. And I think the first rule fits better in browser.css. From what I see, Thunderbird is the only other consumer, and Thunderbird's toolbarbutton labels are messed up anyway in text mode. I'll fix thunderbird in a follow-up.
Attachment #300041 - Flags: review?(mano)
Attachment #300041 - Flags: review?(mano) → review+
Comment on attachment 300041 [details] [diff] [review]
Move the (working) style rule to browser.css (no ui change)

Safe and simple move of a style rule.
Attachment #300041 - Flags: approval1.9?
Comment on attachment 300041 [details] [diff] [review]
Move the (working) style rule to browser.css (no ui change)

a=beltzner
Attachment #300041 - Flags: approval1.9? → approval1.9+
Checking in toolkit/themes/pinstripe/global/toolbar.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/toolbar.css,v  <--  toolbar.css
new revision: 1.15; previous revision: 1.14
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.113; previous revision: 1.112
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Blocks: 414643
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: