414607 - Warning symbol in install confirmation needs to be larger

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Dave Townsend [:mossop]]

The warning symbol used in the install confirmation is quite small on Windows, there is already a larger version available in tree that we should use.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I thought there was already a bug on this, but I can't find it.

Comment 2

[Johnathan Nightingale [:johnath]]

probably want to use something like:

chrome://global/skin/icons/warning-large.png

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Kinda awesome. We're using the global alert-icon here.

By default on windows that is a 32x32 warning icon
On Linux it is a 40x40 sized stock icon.
On OSX it is a 64x64 application icon.

Yay consistency.

This patch splits the xpinstall styles out to be different on windows and linux so we can keep with the stock icon on linux and move to the large icon on windows.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 301888 [details] [diff] [review]
patch rev 1

Needs to be fixed from changes in bug 414597

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 2

This just hardcodes the changed icon for the xpinstall dialog, have to make xpinstallConfirm.css for gnomestripe in it's own right to keep linux with the stock icon, that file is just a straight copy of what is in winstripe now.

Comment 6

[Madhava Enros [:madhava]]

I'm a little sheepish about nominating this, but it's a polish thing and would make us look a lot less odd on windows.  Low priority, but it it's easy to review...

Comment 7

[(not currently active) Ted Mielczarek]

I don't think we can reasonably block on this, sorry. Looks like a simple patch though, maybe we could take this post-beta 5.

Comment 8

[Dave Townsend [:mossop]]

Attachment: using ifdefs

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310030 [details] [diff] [review]
using ifdefs

a1.9=beltzner

Comment 10

[Dave Townsend [:mossop]]

Checking in toolkit/themes/winstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.31; previous revision: 1.30
done
Checking in toolkit/themes/winstripe/mozapps/xpinstall/xpinstallConfirm.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/xpinstall/xpinstallConfirm.css,v  <--  xpinstallConfirm.css
new revision: 1.9; previous revision: 1.8
done