414643 - Fix up Thunderbird's (text-mode) toolbarbutton labels

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Stefan [:stefanh]]

Comment 1

[Stefan [:stefanh]]

Attachment: Fix text-mode labels

+  margin: 5px 4px 3px 4px;

So, how come I don't use margin: 4px as in browser.css? I figured I push down all labels to the tag-button label instead of adding an extra style rule for lifting the tag-button 1px up.

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 300094 [details] [diff] [review]
Fix text-mode labels

r=me, and feel free to land this much if the answer is "another bug," but, what's wrong with that tag button? This brings it in line (at least, to my 1am eyes) except that when you are customizing, it droops back down too low.

Comment 3

[Stefan [:stefanh]]

(In reply to comment #2)
> (From update of attachment 300094 [details] [diff] [review])
> r=me, and feel free to land this much if the answer is "another bug," but,
> what's wrong with that tag button? This brings it in line (at least, to my 1am
> eyes) except that when you are customizing, it droops back down too low.
> 

Now, that was fun:

toolkit/themes/pinstripe/toolbar.css:

.toolbarpaletteitem-box[type="spacer"] {
  border: 1px solid #A3A3A3;
  background: url("chrome://global/skin/10pct_transparent_grey.png") repeat;
  height: 32px !important;
  width: 32px !important;
  margin-top: 18px;
}

.
.
.
.toolbarpaletteitem-box[type="spacer"][place="toolbar"],
.toolbarpaletteitem-box[type="spring"][place="toolbar"] {
  margin: 2px;
}

Customize your toolbar by removing all spacers and notice how the toolbar's height shrink to normal size. Note also that the tag button is happy. So, the spacer has a fixed height and if you want the tag button to be happy it'll need the same label margin as the other buttons.

I'm going to land the patch as it is and see whether people will be happy with a "height: auto !important;" rule.

Comment 4

[Stefan [:stefanh]]

Checking in mail/themes/pinstripe/mail/primaryToolbar.css;
/cvsroot/mozilla/mail/themes/pinstripe/mail/primaryToolbar.css,v  <--  primaryToolbar.css
new revision: 1.14; previous revision: 1.13
done

(this is a Pinstripe fix, so it's mac-only)

Comment 5

[Stefan [:stefanh]]

Btw, see bug 414893 for the .toolbarpaletteitem-box (affects all apps that uses pinstripe) stuff.

Comment 7

[Richard Mlynarik]

Is this supposed to be fixed in any released Thunderbird?
Because it certainly isn't in version 2.0.0.16 (20080707) on MacOS 10.4.11
which was released six months after the patch seems to have been
checked into some branch or another (going by comment #4)

I experimentally manually applied the patch attachment for this bug
https://bugzilla.mozilla.org/attachment.cgi?id=300094
to primaryToolbar.css in
/Applications/Thunderbird.app/Contents/MacOS/chrome/classic.jar
(thank you, Emacs jar-mode) and it seems to work.

It would be really nice if somebody could arrange to migrate this
fix into software that gets released to actual users.  The current
bug has been an irritant for years.

Comment 8

[Magnus Melin [:mkmelin]]

No, just for Thunderbird3 (currently in beta) - see target milestone!