414648 - New addons manager has some minor issues

Status: VERIFIED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Basil Hashem [:baz]]

Congrats on landing the new "Get Add-Ons" work and the new addons interface. It's looking great. I wanted to point out a few minor bugs that I've noticed:

a) The "See All Recommended Add-ons" link doesn't work.
b) After performing a search, pressing "Clear Results" button, clears the list and the search box but keeps the "circle-x" icon in the search field. It should reset it back to the magnifying glass icon.

c) Not sure if this is expected behavior but what I expected if you left-click on the "Browse All Add-ons" text, you'll navigate, I didn't expect that if I right-click on it (wanted to see if it was selectable text or if it had a context menu), it also had the effect of a left-click. That seems odd to me.

d) If I try to install the default addon being shown (tektek.org Gaia toolbar), I get an "Installing..." but it never shows the dialog. Seems like it's hung. No, new "installation" tab shows up - isn't that expected behavior?

e) Installation performance is currently unacceptable (not sure if it's the API or Firefox) as it takes well over 2 minutes before the warning dialog is displayed.

f) Clearing the search while something is being installed puts you in a strange state since you can search again and attempt to install again. Dialog appears for the wrong addon. Exact steps:
- Search for "photo"
- Click "Add to Minefield" on the first addon (A)
- While it's still "Installing", hit "Clear Results"
- Search for "life"
- Click "Add to Minefield" on the first addon (B)

We wait....and what appears is the confirmation dialog for addon (A). That's misleading.

Thanks.

Comment 1

[Dave Townsend [:mossop]]

So some of these are filed as:

a) bug 414602
b) bug 414443
c) bug 414628

d) Can you provide some more details on this

e) This really should be an AMO problem. Does installing direct from an AMO page take the same amount of time since we use exactly the same code to do that?

f) Do you get an install confirmation dialog for addon B following the one for addon A?

Comment 2

[u88484]

e) bug 414682

Comment 3

[Basil Hashem [:baz]]

I appologize for putting too many bugs into a single BZ report, so I wanted to try to close this off.

For d), we now have bug 414795

For e), we now also have bug 414891

So, I'm closing as resolved since we've farmed this into other bugs.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Basil, I had you beat in bug 396739, but I'm not proud of that, and won't be doing it again.

Verified INVALID, per the spin-off bugs.