41466 - Crash when cancelling out of an http authentication

Status: VERIFIED DUPLICATE of bug 41404

(Core :: Networking, defect, P3)

Description

[Stephen P. Morse]

1. Go to a site that requires http authentication.  The one I typically use is 
scopus (inside the netscape firewall) but any other will do as well.

2. Do not enter any information.  Click on cancel (alternately press escape).

3. Crash occurs.  The offending line is on line 1900 of nsHTTPChannel.cpp, 
namley:

    if (!userBuf[0] &&
        (interactionType == nsIAuthenticator::INTERACTION_STANDARD ||
         interactionType == nsIAuthenticator::INTERACTION_NONE)) {

At this point userBuf points to a null array.  My guess is that the fix is to 
change the first line to be

    if (userBuf && !userBuf[0] &&

but I haven't tested that out.

Here's the complete stacktrace at crash time.

nsHTTPChannel::Authenticate(const char * 0x0310e1d0, int 0) line 1899 + 14 bytes
nsHTTPChannel::ProcessAuthentication(int 401) line 2283 + 31 bytes
nsHTTPChannel::ProcessStatusCode() line 2105 + 12 bytes
nsHTTPChannel::FinishedResponseHeaders() line 1996 + 8 bytes
nsHTTPServerListener::FinishedResponseHeaders() line 1063 + 11 bytes
nsHTTPServerListener::OnDataAvailable(nsHTTPServerListener * const 0x0310c8e0, 
nsIChannel * 0x0310dc84, nsISupports * 0x0310bae0, nsIInputStream * 0x0310c85c, 
unsigned int 0, unsigned int 0) line 405 + 8 bytes
nsOnDataAvailableEvent::HandleEvent(nsOnDataAvailableEvent * const 0x0310d8e0) 
line 406 + 47 bytes
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x0310ed20) line 97 + 12 bytes
PL_HandleEvent(PLEvent * 0x0310ed20) line 575 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x010f4160) line 520 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00c30598, unsigned int 49420, unsigned int 0, 
long 17776992) line 1032 + 9 bytes
USER32! 77e71268()
01

Comment 1

[Stephen P. Morse]

Nominating for nsbeta2 since it is a crash.

Comment 2

[Stephen P. Morse]

In step 2, it doesn't matter if you enter any information or not.  So revise 
that step to read  simply:

2. Click on cancel (alternately press escape).

Comment 3

[Andreas Franke (gone)]

Reassigning to [e-mail] because this is a dup of bug 41404.

Comment 4

[Mike Shaver (:shaver emeritus)]

Agreed.


*** This bug has been marked as a duplicate of 41404 ***

Comment 5

[Tom Everingham]

verified Dup.