New application details window spewing errors

VERIFIED FIXED in Firefox 3 beta3

Status

()

Firefox
File Handling
P1
major
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: reed, Assigned: mano)

Tracking

Trunk
Firefox 3 beta3
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
[Spin-off from bug 402252, comment #23]

Ronny Perinke   2008-01-29 14:56:02 PST

If I open the application details for Web-Feed, I get the following two errors.

Fehler: redeclaration of const Cc
Quelldatei: chrome://browser/content/preferences/applications.js
Zeile: 11

Fehler: gApplicationsPane is not defined
Quelldatei: chrome://browser/content/preferences/applicationManager.js
Zeile: 34


It seems that applicationManager.js is loaded before applications.js, because
it defines the constants Ci and Cc. And because of this redeclaration-error,
the 2nd error occurs causing gAppManagerDialog.init to fail.

After commenting out the definitions of const Ci and const Cc
applicationManager.js everything is ok.

My OS is Windows XP. I guess Ci and Cc are not needed at all in
applicationManager.js or it needs an ifdef XP_MACOSX, so that they are only
defined, if they are not in applications.js (note the #ifndef XP_MACOSX there).
Flags: blocking-firefox3?
(Reporter)

Updated

10 years ago
Priority: -- → P1
(Reporter)

Comment 1

10 years ago
Basically, the new feature in bug 402252 is broken on everything but Mac.
Unless we can figure out how to fix this, my preference would be to back out bug 402252.
Flags: blocking-firefox3? → blocking-firefox3+
I'm actually not seeing this on Windows - is it not in the most recent nightly?
(Reporter)

Comment 4

10 years ago
(In reply to comment #3)
> I'm actually not seeing this on Windows - is it not in the most recent nightly?

No, it landed this morning.
Taking.
Assignee: nobody → mano
Status: NEW → ASSIGNED
So myk backed out the bug which broke applications.js, thus the remaining part of this patch is just the manger files.
Attachment #300271 - Flags: review?(gavin.sharp) → review+
mozilla/browser/components/preferences/applicationManager.js 1.2
mozilla/browser/components/preferences/applicationManager.xul 1.2
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Depends on: 415826
Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021804 Minefield/3.0b4pre ID:2008021804

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021804 Minefield/3.0b4pre ID:2008021804
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.