Closed Bug 414821 Opened 12 years ago Closed 12 years ago

Timezone dialog throws error output when timezone of OS doesn't fit to lightning timezone

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: ssitter)

Details

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre Thunderbird/2.0.0.9 ID:2007103104

STEPS TO REPRODUCE:
===================

- set the timezone of your OS to 'Alaska' (Windows XP)
- create a new profile and install lightning
- create an event and enable Options/Timezone
- the timezone is set to 'floating'
- mouse click the Timezone link in the edit menu of this event

RESULT:
=======

- the timezone dialog comes up with this Error Console output:

Error: menuitem has no properties
Source File: chrome://calendar/content/sun-calendar-event-dialog-timezone.js
Line: 81

EXPECTED RESULT:
================

- no error output

REPRODUCIBLE:
=============

- always


If I choose the Alaska timezone on SuSE 10.3 or Mac Leopard the timezone in Lightning is set to America/Alaska and I get no error output.
Flags: blocking-calendar0.8?
Flags: blocking-calendar0.8? → blocking-calendar0.8+
As we agreed upon in the last status call we should remove this from the blocking list.
Flags: blocking-calendar0.8+ → blocking-calendar0.8-
If neither the events timezone nor the users default timezone is contained in the available timezone entries select the first entry as fallback solution.

The STR from Comment #0 don't work anymore. For testing purposes manually set the preference "calendar.timezone.local" to e.g. "floating".
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #304959 - Flags: review?(philipp)
Comment on attachment 304959 [details] [diff] [review]
proposed fix, rev0

>         index = findTimezone(tzname);
>+        if (index < 0) {
>+            index = 0;
>+        }
Sounds reasonable, you could shorten to index = Math.max(0, findTimezone(tzname));

doing so before checkin.
Attachment #304959 - Flags: review?(philipp) → review+
> you could shorten to index = Math.max(0, findTimezone(tzname));

I could, but I'd prefer the explicit if-clause.
Keywords: checkin-needed
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.

--> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: blocking-calendar0.8-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 0.8
OS: Windows XP → All
Hardware: PC → All
checked in nightly build 2008022419 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.