414872 - Change "More Information" text link in identity popup to button

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre Firefox/3.0

Click the Icon in the Location bar and observe that 'Larry' has an ugly focus ring around the link for 'more information' 

The 'More information' is already showing as a clickable link, so I see no need for the focus ring.  At least it should not be there when the end-user is not using any of the accessibility features. 

Reproducible: Always

Steps to Reproduce:
1.
2.
3.


Expected Results:  
No focus ring to make the UI better looking.

Vista HP 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre Firefox/3.0 ID:2008013004

Comment 1

[Marcia Knous [:marcia]]

Confirmed, I see this using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre.

Comment 2

[Victor Bielawski]

On GTK, you could draw a GTK focus rectangle (that nice rounded rectangle that you get around checkbox labels). That would be way less ugly.

Comment 3

[Johnathan Nightingale [:johnath]]

The More Information link should be a button - that's part of the eventual design.  I was going to link to a bug, but I can't find one, so let's use this one to track that change.  Once it's a button, the focus behaviour should look a lot more sensible.  I'll attach a patch soon.

Comment 4

[Johnathan Nightingale [:johnath]]

Attachment: Change to a button, right justified

Simple swap, change the id and simplify the click handler, since we can trust oncommand to fire when and only when it matters.  I'll attach before and after for ui-r.

Comment 5

[Johnathan Nightingale [:johnath]]

Attachment: Right justified button

Okay, I lied, there's only an after, no before.  :)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 301295 [details] [diff] [review]
Change to a button, right justified

>Index: browser/base/content/browser.xul

>-          <label id="identity-popup-more-info-link"

>-                 onblur="getIdentityHandler().hideIdentityPopup();"

This breaks the "tab again to close" behavior, but I'm not sure whether that was intentional. If it's important you could just leave it.

Comment 7

[Johnathan Nightingale [:johnath]]

Attachment: Restore onblur line

Restore the onblur line as mentioned in review comments.  This version has over-the-shoulder ui-r from beltzner.  Nom'ng for approval once the tree re-opens for beta 4.  This patch adds styling that the UX team has wanted for a while in the identity panel, and is very little code change.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 301316 [details] [diff] [review]
Restore onblur line

a=beltzner

Comment 10

[Johnathan Nightingale [:johnath]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.959; previous revision: 1.958
done
Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.428; previous revision: 1.427
done