Closed Bug 414893 Opened 17 years ago Closed 16 years ago

Don't hardcode height of .toolbarpaletteitem-box when on toolbar

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: stefanh, Assigned: stefanh)

Details

(Keywords: verified1.9.1)

Attachments

(1 file, 1 obsolete file)

Better patch, now with some clean-up
1.68 KB, patch
asaf
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
If you for instance drop a spacer on the toolbar when in text-only mode, the toolbar will increase in height. It would be better if the height was set to "auto".

        Attachment #300404 -
        Flags: review?(mano)

    
    

    
  
Comment on attachment 300404 [details] [diff] [review]
Don't hardcode height when on toolbar

Well the title of the attachment is a bit wrong...

        Attachment #300404 -
        Attachment description: Don't hardcode height when in text-only mode → Don't hardcode height when on toolbar

    
    

    
  
Comment on attachment 300404 [details] [diff] [review]
Don't hardcode height when on toolbar

I've been looking at this and I think there's room for some more improvement here... new patch coming up soon ;-)

        Attachment #300404 -
        Flags: review?(mano)

    
    

    
  


  
OK, this is better. Interestingly, the last [place="palette"] rules (height and width) where not used and there was a duplicate border rule.

        Attachment #300404 -
        Attachment is obsolete: true

        Attachment #301296 -
        Flags: review?(mano)

    
  
Target Milestone: mozilla1.9beta4 → mozilla1.9beta5

    
    

    
  
I should probably have said that this will fix an issue with Thunderbird's Tag button that philor discovered in bug 414643...

    
  
Target Milestone: mozilla1.9beta5 → mozilla1.9

    
    

    
  
Comment on attachment 301296 [details] [diff] [review]
Better patch, now with some clean-up

r=mano

        Attachment #301296 -
        Flags: review?(mano) → review+

    
    

    
  
Pushed 359c9f07d014 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9 → mozilla1.9.2a1

    
  
Component: Toolbars and Toolbar Customization → Themes
QA Contact: toolbars → themes

    
  

        Attachment #301296 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 301296 [details] [diff] [review]
Better patch, now with some clean-up

Fixes a small problem with the height of toolbars when they're customized.

        Attachment #301296 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Comment on attachment 301296 [details] [diff] [review]
Better patch, now with some clean-up

a191=beltzner

    
    

    
  
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

    
    

    
  
sorry about that stefanh, here's the Shiretoko build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090413 Shiretoko/3.5b4pre ID:20090413031313

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: