Closed Bug 414922 Opened 17 years ago Closed 17 years ago

RSS Subscription broken

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta3

People

(Reporter: cbook, Assigned: asaf)

References

Details

(Keywords: regression, smoketest)

Attachments

(1 file)

patch
7.33 KB, patch
myk
: review+
beltzner
: approval1.9b3+
Details | Diff | Splinter Review 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008013009 Firefox/3.0b3pre

Its no longer possible to subscribe to a RSS Feed. When you click on the RSS icon on a Website to add a RSS Feed, the Feed Preview comes up (the UI looks at least on mac a little funky now), Click on the Subscribe now button....nothing happens....

Reproduced on Mac and Windows.
Flags: blocking-firefox3?
Maybe due to the forgotten part of the patch in bug 400064?
Target Milestone: --- → Firefox 3 beta3
Priority: -- → P1
Attached patch patch — — Splinter Review 
Assignee: nobody → mano
Status: NEW → ASSIGNED

        Attachment #300480 -
        Flags: review?

    
    

    
  
Comment on attachment 300480 [details] [diff] [review]
patch

The patch looks good and fixes the problem. r=myk

        Attachment #300480 -
        Flags: review? → review+

    
  

        Attachment #300480 -
        Flags: approval1.9b3?

    
    

    
  
Doesn't block beta 3, but would take a patch ...
Flags: blocking-firefox3? → blocking-firefox3+
Target Milestone: Firefox 3 beta3 → Firefox 3 beta4

    
    

    
  
Comment on attachment 300480 [details] [diff] [review]
patch

a=beltzner for regression fix

        Attachment #300480 -
        Flags: approval1.9b3? → approval1.9b3+

    
    

    
  
mozilla/browser/components/feeds/src/FeedWriter.js 1.51
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
  
Target Milestone: Firefox 3 beta4 → Firefox 3 beta3

    
    

    
  
Sorry about that.  Not sure how I tested things for 400064 without catching either of the two issues here, but I think it was from juggling patches and just not doing a clean build between tests.

    
    

    
  
verified fixed using new debug builds Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013022 Minefield/3.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008013014 Firefox/3.0b3pre

thanks will
Status: RESOLVED → VERIFIED

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: