Restart Firefox button missing from UI

NEW
Unassigned

Status

()

Firefox
General
10 years ago
5 years ago

People

(Reporter: vlad, Unassigned)

Tracking

({regression})

Trunk
Future
regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 -
wanted-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

This button got removed in bug 408116, completely regressing bug 369075.  I understand there is an infobar that comes down *when firefox feels like letting you restart*, but the ability to restart was generally useful (modifying things such as installing system-global plugins), and was a workaround for some cases (firefox using too much memory).  Ideally magic would happen and all those would cases would be fixed, but they won't be anytime soon.

Please bring back the restart button and/or add equivalent functionality elsewhere -- removing the button without adding the same functionality elsewhere in the UI is not a good plan.
Flags: blocking-firefox3?
Blocks: 408116
Hardware: PC → All

Updated

10 years ago
Blocks: 369075

Updated

10 years ago
Keywords: regression
I'd like to see a permanent restart which would be used for non EM reasons outside of the add-ons ui where it would take up ui real estate that is better used for managing add-ons.

I don't see why the EM should be the component for this reason and if you agree Vlad I'd like to me this over to General. Otherwise, I would want reasons as to why the EM should contain this ui.
IMHO a permanent toolbar button and/or (preferably and) a "File -> Restart <appname>" menu item would be great. They should apply not only to Firefox but also to Thunderbird and "suiterunner" SeaMonkey but I don't know whether this means three bugs or just one.

Workaround: Install "MR Tech Local Install" extension, https://addons.mozilla.org/en-US/firefox/addon/421

Comment 3

10 years ago
My two cents.... i'm still not sure why a permanent restart button would be really useful, other than adding/removing extensions/themes/plugins.  I may be wrong, but dont recall other popular browser having a restart button on chrome or menu?   Users are used to restarting firefox, like any other desktop app, but shutting down and relaunching.  
to add to Tony's statement I believe that any condition where the restart button is not shown as it relates to managing add-ons should be handled by displaying the button in the add-ons mgr. instead of displaying it all of the time. So, if there are additional cases where it isn't displayed they should be filed as a separate bug and for the cases where someone wants it displayed for non EM reasons then a bug for the appropriate component should be filed where it can be decided by UX whether it should be added, etc.
In reply to comment #3

There are a number of preferences, and a number of extension settings, which require restart in order to take effect. Also, changes to <profile>/chrome/user*.css and <profile>/user.js will only take effect on restart (changes in the latter are rarely, but not "never", preferable to using about:config).

Of course, it is possible to
- click File -> Quit
- wait for the application to "really" exit, which can take from a few seconds to number of minutes depending, among other things, on the number of open tabs in the current session
- start the application again
but having a "restart" button or menuitem (or both) is much less trouble. I find it useful.

Why imitate the bad points of other browsers, just because "they" do it that way?
Moved to firefox general, I agree.

Beltzner had a good suggestion -- put the restart button in about:config.  I'd say that'd be a baseline fix, and then a separate discussion as to whether restarting is a generally useful browser feature.
Component: Extension/Theme Manager → General
QA Contact: extension.manager → general
(In reply to comment #6)
> Moved to firefox general, I agree.
> 
> Beltzner had a good suggestion -- put the restart button in about:config.  I'd
> say that'd be a baseline fix, and then a separate discussion as to whether
> restarting is a generally useful browser feature.
> 

A button in about:config? Hm, I guess it would take some getting used to, but why not? I would have preferred a button in reserve, ready to be "customized" onto the toolbars, but as long as it's a "permanent" button (and "discoverable" haha), I'm not really picky about where it gets put.

I don't know whether "restarting" is, in general, or even on average, a "generally useful feature"; but I'm convinced that _the ability to decide_ that one wants an easy single-click way to restart, _that_ is a generally useful feature, which doesn't hurt the people who'll decide not to avail themselves of it.

Comment 8

10 years ago
Taking over.
Assignee: nobody → ehsan.akhgari
Target Milestone: --- → Firefox 3 beta4

Comment 9

10 years ago
Created attachment 300875 [details] [diff] [review]
Patch (v1)

This patch adds the Restart button to about:config.  I'll be attaching a screenshot for ui-review right away.
Attachment #300875 - Flags: review?(mano)

Comment 10

10 years ago
Created attachment 300876 [details]
Screenshot

Screenshot for ui-review.
Attachment #300876 - Flags: ui-review?(beltzner)

Comment 11

10 years ago
BTW, this bug adds the string for the restart button, so it should be late-l10n.
Keywords: late-l10n

Comment 12

10 years ago
If we got rid of the button in the add-ons manager in favor of the notification bar, why would we add the button in about:config and not use the notification bar?

Comment 13

10 years ago
Because that notification bar is not visible all the time, but users may need to restart the application for other reasons.  For examples, see comment 0.

Comment 14

10 years ago
so by hiding it in about:config is going to be quicker than closing firefox and double-clicking the shortcut?

If this patch lands, this would be the steps to see the restart button:

1) select location bar
2) delete address
3) type in about:config, hit enter
4) read warning message about this gun is loaded (i can't remember what the new text reads)
5) hit proceed or whatever the button is labeld
6) now click the restart button

That is why I say we should just leave it to extensions to add a restart button.  But if the higher beings insist about:config needs a restart button, why not still use the notification bar?  Just would have to code to look /listen for user modified changes in about:config and then present the restart notification bar.
c#14:
> But if the higher beings insist about:config needs a restart button,
> why not still use the notification bar?
> Just would have to code to look/listen for user modified changes in
> about:config and then present the restart notification bar.

c#13:
> Because that notification bar is not visible all the time, but users may need
> to restart the application for other reasons.  For examples, see comment 0.
(In reply to comment #14)
> so by hiding it in about:config is going to be quicker than closing firefox and
> double-clicking the shortcut?
> 
> If this patch lands, this would be the steps to see the restart button:
> 
> 1) select location bar
> 2) delete address

(1 and 2) hit Ctrl-L, which selects the whole URL. Typing anything will replace it.

> 3) type in about:config, hit enter
> 4) read warning message about this gun is loaded (i can't remember what the new
> text reads)

that message is only displayed once (or did I have to tell the browser I didn't want it again?) In any case, I don't see it anymore. Go to step 6.

> 5) hit proceed or whatever the button is labeld
> 6) now click the restart button
> 
> That is why I say we should just leave it to extensions to add a restart
> button.  But if the higher beings insist about:config needs a restart button,
> why not still use the notification bar?  Just would have to code to look
> /listen for user modified changes in about:config and then present the restart
> notification bar.
> 

Note that steps 1 to 5 are unnecessary if we just changed one of the few prefs which won't take effect without a restart. Also, if I find out I often need that button, I'm gonna find a way (such as a bookmark) to open about:config with the least possible hassle.

Why not use the notification bar? Because the notification bar might not be displayed when I (the user, not the browser) decide that it's time to restart. Remember, the notification bar is _only_ there when some extension is pending for install, uninstall, enable, disable, or upgrade, when a theme is pending activation, or when the currently active theme is pending upgrade. If I want to restart because I just made changes in userChrome.css, where's the notification bar? Probably nowhere in sight.

Also, with a button on a toolbar (which can be displayed, hidden, or moved about by "customizing" the bookmarks), the button is always there (if "a user who needs it" has put it on his toolbars). Just one click. However this semms not to be how ThePowersThatBe think "is best for me". <shrug />

Comment 17

10 years ago
This is definitely a must have, a tiny change, but would solve many problems, and sure will make firefox better than others like IE7, safari3 etc.

Its about usability, small thing makes wonder.

Put it in "Help" menu, or wherever easy to access. definitely a MUST.

Comment 18

10 years ago
Or put 'Restart' in the 'File' menu, right above 'Exit'.
This does not block the final release of Firefox 3.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-

Comment 20

10 years ago
Beltzner: waiting for your input on the UI for this bug.  Is the button in about:config (attachment 300876 [details]) good enough?  Or should we go with other proposals, such as the Restart menu item in the File menu?
Status: NEW → ASSIGNED
Comment on attachment 300875 [details] [diff] [review]
Patch (v1)

This should use a dtd file (along with brand.dtd, that is)
Attachment #300875 - Flags: review?(mano) → review-

Comment 22

10 years ago
Created attachment 303680 [details] [diff] [review]
Patch (v1.1)

(In reply to comment #21)
> (From update of attachment 300875 [details] [diff] [review])
> This should use a dtd file (along with brand.dtd, that is)

Done.
Attachment #300875 - Attachment is obsolete: true
Attachment #303680 - Flags: review?(mano)

Comment 23

10 years ago
(In reply to comment #10)
> Created an attachment (id=300876)

This will (annoyingly) break muscle memory: Currently you enter a filter string, then double-Tab to the listbox and hit Enter to change the found value. With this change you'll have to make absolutely sure that you tripple-Tab...

IMO this is extension fodder, but if you really have to add a further gimmick, please at least make sure to append it to the tab order (so that you reach it _after_ the listbox), leading to a more natural order: (1) Filtering, (2) pref changing, (3) restarting, where you'll just have to Tab once more after (2).

Comment 24

10 years ago
Created attachment 303824 [details] [diff] [review]
Patch (v1.2)

Address Simon's valid criticism in comment 23.
Attachment #303680 - Attachment is obsolete: true
Attachment #303824 - Flags: review?(mano)
Attachment #303680 - Flags: review?(mano)
Comment on attachment 300876 [details]
Screenshot

I think it's a little dangerous where it's located, and would suggest instead putting it on the bottom right.

I'm kinda thinking comment 23 is right, though, that this is extension fodder.
Attachment #300876 - Flags: ui-review?(beltzner) → ui-review-

Comment 26

10 years ago
(In reply to comment #25)
> (From update of attachment 300876 [details])
> I think it's a little dangerous where it's located, and would suggest instead
> putting it on the bottom right.

Hmm, that would cause a new row with only the Restart button on the row, which may look strange, but if you think that's alright, I'll prepare a patch.

What about the File menu, above Exit?  That looks like a perfect place for this item, doesn't it?

> I'm kinda thinking comment 23 is right, though, that this is extension fodder.

Hmm, see comment 5.

Beltzner: please let me know your final call on this.  Thanks!

Updated

10 years ago
Attachment #303824 - Attachment is obsolete: true
Attachment #303824 - Flags: review?(mano)

Updated

10 years ago
Attachment #300876 - Attachment is obsolete: true
So, I think what I really want is a restart button at the bottom, but I don't want it bad enough to break string freeze and I don't think it's essential for Firefox 3. Let's get this right in the next release.

Comment 28

10 years ago
OK, let's have it at the next release.  Is this something which can be added in a point release?
Keywords: late-l10n
Target Milestone: Firefox 3 beta4 → Future

Updated

10 years ago
Duplicate of this bug: 421964
(In reply to comment #28)
> OK, let's have it at the next release.  Is this something which can be added in
> a point release?

The next release and its string freeze is getting closer, maybe we should get this on track.
Flags: wanted-firefox3.1?
There used to be an extension for this based on bug 336050 which added Restart to the File menu, but the developer probably thinks it is no longer needed with FX3: https://addons.mozilla.org/en-US/firefox/addon/3458

I'd still like to be able to restart Firefox and Thunderbird when I feel like it. Putting this option in about:config won't make it easily accessible, so it will be easier to just kill Firefox and start it up again.

If the rationale to put it as a button in about:config is that it will only be needed if a user changes a setting, than a more elegant solution will be to add an event listener to that preference and if it changes put up the notification bar (in about:config or in menu "tools -> options" or in menu "tools -> addons" if an extension wants this...
In reply to comment #31:

The Restart button still exists in the MR Tech Toolkit extension https://addons.mozilla.org/en-US/seamonkey/addon/421 -- however that extension includes a lot of other things which can be regarded, depending on POV, as "indispensable features", as "useless bloat", or as anything in between. That extension currently boasts support of Firefox 2.0 to 3.1b1pre, Thunderbird 2.0 to 3.0b1pre and SeaMonkey 1.5a to 2.0a1. Maybe other apps too, I haven't checked.

Updated

8 years ago
Duplicate of this bug: 512963

Comment 34

8 years ago
Updating to reality: I won't have the time to work on this for the foreseeable future!
Assignee: ehsan.akhgari → nobody
Status: ASSIGNED → NEW
Firefox 3.5 has come and gone (or almost), Firefox 3.6 (mozilla-1.9.2) is "current stable" which I suppose means it won't get it, so I guess the earliest possible milestone is 1.9.3 (current trunk). Not that I have many illusions about ever seeing this feature in mainstream Firefox / Thunderbird / SeaMonkey -- and there are circumstances when a restart is needed and the addons manager doesn't know about it, at least for people like me, who make changes in userC*.css, have extensions some of whose settings require a new window to take effect (and when it is a 3-pane mail window or a 90-tab browser window...) and use about.config (which usually works with no restart, *but not always*), not to mention srange sporadic but annoying bugs which sometimes disappear (at least temporarily) on restart. Also, sometimes I install or upgrade an extension but still have things to do with the browser or mailer before restarting -- and when the time is right, I'm not looking at the addons manager anymore; so a Restart button in the main chrome or a Restart menuitem in one of the main menus (or both) would be a nice thing to have. (And yes, as already mentioned I use MR-Tech Toolkit, but it doesn't yet support trunk nightlies, and I'm sure there are people who think that that extension is "bloat" but would like a Restart button.)
status2.0: --- → ?
Flags: wanted-firefox3.5?

Updated

7 years ago
status2.0: ? → ---

Updated

5 years ago
Duplicate of this bug: 871562
See also the "Restartless Restart" extension https://addons.mozilla.org/en-US/firefox/addon/restartless-restart/ which adds a customizable toolbar button and a File→Restart menuitem

Comment 38

5 years ago
Well we normally only need to restart due to some bug,
and we can't report a bug well without first turning off extensions...
I'm not 100% sure about Firefox, but in SeaMonkey there is a menuitem "Help → Restart with Add-ons disabled" to restart in Safe Mode. When I click that menuitem, I get a popup with a checkbox, "[x] Restart with add-ons disabled". Unticking that lets me initiate a normal restart, even from Safe Mode and even from a virgin profile with no add-ons in it.
But after restarting with add-ons disabled and having tested what you wanted to test, there's no way to restart again with add-ons enabled again...
Created attachment 749762 [details]
safe mode restart prompt screenshot

In reply to comment #40:
Haven't you got this popup and checkbox? This is what I get on SeaMonkey when I click "Help → Restart with Add-Ons Disabled". Unticking the checkbox followed by clicking "Restart" gives me a normal restart, with add-ons enabled.
Created attachment 749782 [details]
Safe mode restart prompt for Firefox and Thunderbird

In both Firefox and Thunderbird there's no "Restart with add-ons disabled" to check or uncheck in the popup window.
You need to log in before you can comment on or make changes to this bug.