414963 - C++ warnings in jsnum.c, jsutil.c (with g++ -Wconversion)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

These lines in jsnum.c cause errors when building with g++ -Wconversion (which is what the Mozilla build does in actionmonkey branch, bug 357016):

  http://mxr.mozilla.org/mozilla/source/js/src/jsnum.c#781
      return (int32) (d >= two31) ? (d - two32) : d;
  http://mxr.mozilla.org/mozilla/source/js/src/jsnum.c#810
      return (uint32) (d >= 0) ? d : d + two32;

It's just a thinko regarding operator precedence; see patch.

There's also a spot in jsutil.c where g++ wants a cast:

  http://mxr.mozilla.org/mozilla/source/js/src/jsutil.c#201
      cnt = ceil(log10(cnt));

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

I thought I uploaded this last week.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 301033 [details] [diff] [review]
v1

Thanks. Safe to land to cut down on warnings in Moz2 builds, won't hurt 1.9 builds and may avoid warnings there too (I did not see any on Mac gcc builds, debug or opt).

/be

Comment 3

[Reed Loden [:reed]]

Checking in js/src/jsnum.c;
/cvsroot/mozilla/js/src/jsnum.c,v  <--  jsnum.c
new revision: 3.104; previous revision: 3.103
done
Checking in js/src/jsutil.c;
/cvsroot/mozilla/js/src/jsutil.c,v  <--  jsutil.c
new revision: 3.29; previous revision: 3.28
done