414974 - Regression: User should not be able to delete system(?) folders in Library left pane - Bookmarks Toolbar, Bookmarks Menu, Unfiled Bookmarks

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre

I know there was another bug which addressed this and which was fixed, but am not able to locate it. If someone knows about that bug, kindly re-open the same.

Basically, in the Libarary left-pane as well as sidebar, a user should not be able to delete 'Bookmarks Menu', 'Bookmarks Toolbar' and 'Unfiled Bookmarks' folders. 'delete' option should be disabled in their respective context menus.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[ronin.achilles]

Attachment: Library left pane context menu - 'Delete' option is enabled

Screenshot showing the 'delete' option, which is enabled in the current builds, where it should ideally be disabled for these three default folders.

Comment 2

[Asaf Romano (gone)]

So, you can only remove the shortcuts, this doesn't actually remove the folders themselves. That said, we shouldn't allow removing this special queries. Patch coming.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

drivers: very low risk.

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 300515 [details] [diff] [review]
patch

r=me

Comment 5

[Asaf Romano (gone)]

Attachment: the right patch

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 300517 [details] [diff] [review]
the right patch

ok, r=me

Comment 7

[Asaf Romano (gone)]

Comment on attachment 300517 [details] [diff] [review]
the right patch

note to self: s/PlacesUtils.itemHasAnnotation/PlacesUtils.annotations.itemHasAnnotation/

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/places/content/controller.js 1.196

Comment 9

[Mike Lierman]

*** VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv