Last Comment Bug 414982 - Use gcZeal setting in nsJSEnvironment, as we once did with WAY_TOO_MUCH_GC
: Use gcZeal setting in nsJSEnvironment, as we once did with WAY_TOO_MUCH_GC
: fixed1.8.1.15
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla1.9beta3
Assigned To: Brian Crowder
: Andrew Overholt [:overholt]
Depends on:
Blocks: 308429 426628
  Show dependency treegraph
Reported: 2008-01-30 16:00 PST by Brian Crowder
Modified: 2008-06-04 11:53 PDT (History)
5 users (show)
dveditz: blocking1.8.1.15+
dveditz: wanted1.8.1.x+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch, v1 (2.28 KB, patch)
2008-01-30 16:10 PST, Brian Crowder
bzbarsky: review+
bzbarsky: superreview+
mtschrep: approval1.9b3+
brendan: approval1.9+
Details | Diff | Splinter Review

Description Brian Crowder 2008-01-30 16:00:10 PST
As bz notes in bug 308429, I did not properly convert a WAY_TOO_MUCH_GC preprocessor guard in nsJSEnvironment to use the new runtime gcZeal parameter.  This patch does that.

It also fixes a warning I noticed while testing my change.
Comment 1 Brian Crowder 2008-01-30 16:10:24 PST
Created attachment 300527 [details] [diff] [review]
patch, v1

Could've sworn I added this attachment the first time.  :(
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2008-01-30 16:17:14 PST
Comment on attachment 300527 [details] [diff] [review]
patch, v1

Looks good.
Comment 3 Brian Crowder 2008-01-30 16:22:54 PST
Comment on attachment 300527 [details] [diff] [review]
patch, v1

Would be pretty harmless for b3, but I'll gladly settle for 1.9 approval and then I'll throw a checkin-needed on it.
Comment 4 Brendan Eich [:brendan] 2008-01-30 16:36:25 PST
Comment on attachment 300527 [details] [diff] [review]
patch, v1

This should go in for sure, and it could be useful in b3. It is safe.

Comment 5 Brian Crowder 2008-01-31 07:59:35 PST
If someone has an opportunity to land this for me today, that would be great.  Thanks.
Comment 6 Reed Loden [:reed] (use needinfo?) 2008-01-31 11:03:19 PST
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.385; previous revision: 1.384
Comment 7 Daniel Veditz [:dveditz] 2008-04-02 15:05:58 PDT
Probably wanted on the 1.8 branch
Comment 8 Brian Crowder 2008-06-03 08:30:37 PDT
Should clear the wanted/blocking flags on these bugs, as they are replaced for the 1.8 branch by the rollup patch in bug 426628.

Note You need to log in before you can comment on or make changes to this bug.