The default bug view has changed. See this FAQ.

Use gcZeal setting in nsJSEnvironment, as we once did with WAY_TOO_MUCH_GC

RESOLVED FIXED in mozilla1.9beta3

Status

()

Core
DOM
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Brian Crowder, Assigned: Brian Crowder)

Tracking

({fixed1.8.1.15})

Trunk
mozilla1.9beta3
fixed1.8.1.15
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1.15 +
wanted1.8.1.x +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
As bz notes in bug 308429, I did not properly convert a WAY_TOO_MUCH_GC preprocessor guard in nsJSEnvironment to use the new runtime gcZeal parameter.  This patch does that.

It also fixes a warning I noticed while testing my change.
(Assignee)

Comment 1

9 years ago
Created attachment 300527 [details] [diff] [review]
patch, v1

Could've sworn I added this attachment the first time.  :(
Attachment #300527 - Flags: superreview?(bzbarsky)
Attachment #300527 - Flags: review?(bzbarsky)
Comment on attachment 300527 [details] [diff] [review]
patch, v1

Looks good.
Attachment #300527 - Flags: superreview?(bzbarsky)
Attachment #300527 - Flags: superreview+
Attachment #300527 - Flags: review?(bzbarsky)
Attachment #300527 - Flags: review+
(Assignee)

Comment 3

9 years ago
Comment on attachment 300527 [details] [diff] [review]
patch, v1

Would be pretty harmless for b3, but I'll gladly settle for 1.9 approval and then I'll throw a checkin-needed on it.
Attachment #300527 - Flags: approval1.9?
Comment on attachment 300527 [details] [diff] [review]
patch, v1

This should go in for sure, and it could be useful in b3. It is safe.

/be
Attachment #300527 - Flags: approval1.9b3?
Attachment #300527 - Flags: approval1.9?
Attachment #300527 - Flags: approval1.9+

Updated

9 years ago
Attachment #300527 - Flags: approval1.9b3? → approval1.9b3+
(Assignee)

Comment 5

9 years ago
If someone has an opportunity to land this for me today, that would be great.  Thanks.
Keywords: checkin-needed
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.385; previous revision: 1.384
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta3
Probably wanted on the 1.8 branch
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.15?
Blocks: 426628
Flags: blocking1.8.1.15? → blocking1.8.1.15+
(Assignee)

Comment 8

9 years ago
Should clear the wanted/blocking flags on these bugs, as they are replaced for the 1.8 branch by the rollup patch in bug 426628.
(Assignee)

Updated

9 years ago
Keywords: fixed1.8.1.15
You need to log in before you can comment on or make changes to this bug.