Bookmark Contextual Dialog: sometimes the folders in the treeview cannot be collapsed

RESOLVED INCOMPLETE

Status

()

Firefox
Bookmarks & History
RESOLVED INCOMPLETE
10 years ago
9 years ago

People

(Reporter: u286998, Unassigned)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013004 Minefield/3.0b3pre

Most of the time when clicking the twisty in the folder treeview only the twisty changes state but the folder is not collapsed or expanded

Reproducible: Sometimes

Steps to Reproduce:
1.
2.
3.

Updated

10 years ago
Version: unspecified → Trunk

Comment 1

10 years ago
I see this in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050406 Minefield/3.0pre 
and
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5.

The right MSAA events in Windows are fired, but the UI doesn't change.  (Apparently only when a screen reader is running.   I think this needs to be converted to an accessibility bug or added as a separate bug, especially if I'm talking about a different part of Firefox.)

This happens when I click on the twisty or try to open/close it with left/right arrow.

Start Window-Eyes and accevent.
My steps are open the "Edit this Bookmark" dialog with Control D.
Tab to the "show all bookmarks folder" and hit enter. (the dialog closes)
Open the dialog again with Control D.
Tab to the tree view.
left and right arrow on items with twistys.

I would expect them to open and close. Instead the treeview doesn't change.

If you have accevent and Window-Eyes running, you'll see valid state change events, but the UI doesn't update except for the twisty changing from a + to a - or back.

If Window-Eyes is not running, you can get the twistys to start working again, but I'm not sure the exact steps to repair them.
(Reporter)

Comment 2

10 years ago
i am not able to reproduce this anymore and didn't have a screenreader running when i created this bug. i guess the original issue is fixed and this bug could be converted to your description

Comment 3

10 years ago
If I open the treeview of bookmarks by selecting "Choose..." in the Folder combobox, the treeview works correctly both visually and with its MSAA events.
(In reply to comment #1)
> My steps are open the "Edit this Bookmark" dialog with Control D.
> Tab to the "show all bookmarks folder" and hit enter. (the dialog closes)

This one insists on being activated with the SPACE BAR, as should be standard for all buttons. ENTER usually executes the default action in a dialog, and in my opinion it should never be allowed to activate the currently focused button.

I just tried using SPACE instead of ENTER, and it works fine for me.

Comment 5

10 years ago
I didn't mean that the closing was a problem--Actually, until you reminded me about the space bar, I thought that closing was the normal behavior.   

What I saw as a problem was that the treeview doesn't work when you go back into edit bookmarks after hitting Enter .   

You're right though, enter should have activated the default control - which normally is the "OK" button.   If that wouldn't break the dialog the next time it comes up, I'd be happy too.
Bulk closing all UNCONFIRMED bugs dealing with places that haven't had any bug activity in over 120 days, have no votes, and are not enhancement requests.

If you are still experiencing this issue in Firefox 3.0 or later, please re-open the bug with steps to reproduce (if they were not part of the original comment).
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INCOMPLETE

Comment 7

10 years ago
William, can you reproduce the bug with or without Windows Eyes still?

Comment 8

10 years ago
Yes, it can still happen even when Window-Eyes has never run.

One way to get the twistys to start working again is to click with the mouse on the "hide" button.   You can then click on show all to open a working instance of the treeview, without needing to close the dialog.   

Today I tested with Firefox 3.0.4 that Firefox updated this morning.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.