Closed Bug 415060 Opened 13 years ago Closed 13 years ago
.append Item and .insert Item At should return the new menuitem
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:188.8.131.52) Gecko/20071127 Firefox/184.108.40.206 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013103 Minefield/3.0b3pre According to nsIDOMXULContainerElement.idl, appendItem and insertItemAt return nsIDOMXULElement, but on latest trunk, these method return nothing. Reproducible: Always
the patch looks ok
Drivers: this is a simple, no-risk API correctness fix for the patch landed in bug 372552. Surkov: can we get the testcase from bug 372552 (attachment 259102 [details]) landed, and add a test for this bug to it?
(In reply to comment #3) > Surkov: can we get the testcase from bug 372552 (attachment 259102 [details]) landed, and > add a test for this bug to it? > I'll put mochitest under content/tests/widgets
Comment on attachment 301245 [details] [diff] [review] mochitest Looks good, but use the 'is' function instead of 'ok'. As in: is(menu.itemCount, 2, "blah blah"); Also, use consistent spacing around the parentheses.
Attachment #301245 - Flags: review?(neil) → review+
Comment on attachment 301269 [details] [diff] [review] combined patch a1.9+=damons
Attachment #301269 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.