415062 - Bookmark this Link - Cancel not working

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013102 Minefield/3.0b3pre Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013102 Minefield/3.0b3pre Firefox/3.0

Right-clicking on a 'link' and using 'Bookmark this Link' brings up the Bookmarking Dialog, however the Cancel button is not working, and the bookmark is added to the Bookmarks Menu.

Reproducible: Always

Steps to Reproduce:
1. right-click a link
2. Click:  Bookmark this Link
3. Click:  Cancel 
4. Check your Bookmarks Menu and note the bookmark was added when it should not have been added.
Actual Results:  
Bookmark Added

Expected Results:  
Clicking 'Cancel' should not add the bookmark. 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013102 Minefield/3.0b3pre Firefox/3.0 ID:2008013102

Vista HP

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

It should be noted also that Ctrl+D or Right-click Bookmark this Page - the 'Cancel' button works as expected, no bookmark added. 

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008013104 Firefox/3.0.0.0 ID:2008013104

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

Now with this build - strange things once again.  

Now Right-click Bookmark this link does 'nothing'. No bookmark created, no Dialog box is displayed. 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008013116 Minefield/3.0b3pre Firefox/3.0 ID:2008013116

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, anytime you create a bookmark *other* than through clicking on the star dialog, cancel should undo the create operation.

Comment 5

[Michael Schonfeld]

Attachment: v1

Comment 6

[Asaf Romano (gone)]

Comment on attachment 303036 [details] [diff] [review]
v1

r=mano.

Comment 7

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js, 1.94

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

Confirmed - working OK in latest hourly containing the patch. 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021307 Minefield/3.0b4pre Firefox/3.0 ID:2008021307

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv