415213 - uninitialized variables in PSM

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kai Engert [:KaiE:]]

Thanks to reed for reporting this.
Apparently I always built in debug mode, and I was unaware that gcc will not report some warnings when building without optimization! (weird)

I've inspected the sources, and I think none of these is an issue, because the logic ensures the variables will be initialized before the variables are read.

So, a fix to these warnings will be of cosmetic nature, but we should do it anyway.

nsSecureBrowserUIImpl.cpp
/home/kaie/moz/head/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp: In member function 'nsresult nsSecureBrowserUIImpl::UpdateSecurityState(nsIRequest*)':
/home/kaie/moz/head/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp:999: warning: 'warnSecurityState' may be used uninitialized in this function
nsRecentBadCerts.cpp
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsRecentBadCerts.cpp: In member function 'virtual nsresult nsRecentBadCertsService::GetRecentBadCert(const nsAString_internal&, nsISSLStatus**)':
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsRecentBadCerts.cpp:99: warning: 'isUntrusted' may be used uninitialized in this function
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsRecentBadCerts.cpp:98: warning: 'isNotValidAtThisTime' may be used uninitialized in this function
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsRecentBadCerts.cpp:97: warning: 'isDomainMismatch' may be used uninitialized in this function
nsSSLThread.cpp
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsSSLThread.cpp: In static member function 'static PRInt32 nsSSLThread::requestWrite(nsNSSSocketInfo*, const void*, PRInt32, PRIntervalTime)':
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsSSLThread.cpp:719: warning: 'my_ssl_state' may be used uninitialized in this function
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsSSLThread.cpp: In static member function 'static PRInt32 nsSSLThread::requestRead(nsNSSSocketInfo*, void*, PRInt32, PRIntervalTime)':
/home/kaie/moz/head/mozilla/security/manager/ssl/src/nsSSLThread.cpp:492: warning: 'my_ssl_state' may be used uninitialized in this function

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch v1

Comment 2

[Damon Sicore (:damons)]

Comment on attachment 300832 [details] [diff] [review]
Patch v1

a1.9+=damons

Comment 3

[Kai Engert [:KaiE:]]

fixed