Created attachment 300897 [details] [diff] [review] Security use of NSPR rotate macros Replace several uses of shift/xor, intended to rotate bits, with the use of the new NSPR rotate macros. The goal is to improve performance by replacing the existing code with the hardware rotate instructions that the macros alias.
Thanks for the patch. Nelson already checked in the changes to mozilla/security/nss (see bug 331043 comment 97). MD4 is an old, broken hash algorithm. It is not worth our time to optimize our MD4 implementation. So I'm not going to check in the change to mozilla/security/manager/ssl/src/md4.c.
Comment on attachment 300970 [details] [diff] [review] Use the equivalent PR_ROTATE_LEFT32 calls r=nelson
Comment on attachment 300970 [details] [diff] [review] Use the equivalent PR_ROTATE_LEFT32 calls I checked in this patch on the NSS trunk. Checking in lib/base/hash.c; /cvsroot/mozilla/security/nss/lib/base/hash.c,v <-- hash.c new revision: 1.11; previous revision: 1.10 done Checking in lib/pki/pkistore.c; /cvsroot/mozilla/security/nss/lib/pki/pkistore.c,v <-- pkistore.c new revision: 1.32; previous revision: 1.31 done