415426 - trace-malloc broken on fxdbug-win32-tbox (due to Vista SDK?)

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

fxdbug-win32-tbox is burning with:

Building deps for /e/builds/tinderbox/Fx-Trunk-Memtest/WINNT_5.2_Depend/mozilla/tools/trace-malloc/lib/nsDebugHelpWin32.cpp
cl -FonsDebugHelpWin32.obj -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"WINNT5.2\" -DOSARCH=WINNT  -I/e/builds/tinderbox/Fx-Trunk-Memtest/WINNT_5.2_Depend/mozilla/tools/trace-malloc/lib -I. -I../../../dist/include/xpcom -I../../../dist/include   -I../../../dist/include/tracemalloc -I../../../dist/include/nspr    -DLCMS_DLL -I../../../dist/sdk/include       -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdtracemalloc.pdb  -DDEBUG -D_DEBUG -DDEBUG_cltbld -DTRACING -Zi -MDd           -D_CRT_SECURE_NO_DEPRECATE=1 -D_CRT_NONSTDC_NO_DEPRECATE=1 -DWINVER=0x500 -D_WIN32_WINNT=0x500 -D_WIN32_IE=0x0500 -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"1.9b3pre\" -DMOZILLA_VERSION_U=1.9b3pre -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDING_LEVEL_MINIMAL=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1 -DMOZ_DEFAULT_TOOLKIT=\"cairo-windows\" -DMOZ_THEBES=1 -DMOZ_CAIRO_GFX=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_XTF=1 -DMOZ_CRASHREPORTER=1 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_SVG_FOREIGNOBJECT=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_PLACES=1 -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_LOGGING=1 -DNS_TRACE_MALLOC=1 -DMOZ_USER_DIR=\"Mozilla\" -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DMOZ_REFLOW_PERF=1 -DMOZ_REFLOW_PERF_DSP=1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /e/builds/tinderbox/Fx-Trunk-Memtest/WINNT_5.2_Depend/mozilla/tools/trace-malloc/lib/nsDebugHelpWin32.cpp
nsDebugHelpWin32.cpp
e:/builds/tinderbox/Fx-Trunk-Memtest/WINNT_5.2_Depend/mozilla/tools/trace-malloc/lib/nsDebugHelpWin32.cpp(226) : error C2664: 'BOOL (HANDLE,PENUMLOADED_MODULES_CALLBACK,PVOID)' : cannot convert parameter 2 from 'overloaded-function' to 'PENUMLOADED_MODULES_CALLBACK'
        None of the functions with this name in scope match the target type
make[4]: *** [nsDebugHelpWin32.obj] Error 2

(http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1202038440.1202039353.14921.gz)

This started happening after bug 414894 landed and the box was clobbered to fix the resulting crashes running the bloat test. It's had a further two manual clobbers.

Normally this box does depend builds only, so clobber builds could be busted for some time without us knowing. (Unfortunately, there's no way to figure out when the last clobber build was without inspecting all the logs.) Can't see any changes in trace-malloc recently, but the Vista SDK was installed early in January - the current reference platform is described at
http://wiki.mozilla.org/ReferencePlatforms/Win32#January_2008_Update.2FRefresh

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hrm.  I thought I ran into this and fixed it before (bug 391848 comment 21), but it's interesting that only one of the two errors is happening here.

Is there an easy way for me to look at the header files in the Vista SDK?  I suppose I could just install it...

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, except the one I fixed before was in a different file.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in that may or may not break old SDKs; if it does we can switch to casts and actually explain why we need them.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Switched back to casts.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Here's what I checked in to fix this bug (across three checkins).  It makes the signatures match the new SDK and leaves/adds casts so that it will build against both new and old.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 301148 [details] [diff] [review]
patch

Requesting after-the-fact review and approval for this bustage fix needed to get the Windows leak test tinderbox green again.

It's pretty low risk, since even though we do ship the code in the first file patched, it's not going to be called from non-DEBUG builds unless people are using debugging tools.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 301148 [details] [diff] [review]
patch

post-hoc-a=beltzner