415484 - Form data isn't saved at shutdown

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Simon Bünzli]

Steps to reproduce:
1. Open a new tab and go to www.google.com
2. Enter a search term
3. Close Firefox (confirming to Save and Quit)
4. Open Firefox again

Expected result:
The search term has been restored.

Actual result:
It's gone.

This still works as expected when closing just the www.google.com tab and reopening it - and it seems to also work on restart (which should be the exact same code path as shutdown).

Comment 1

[Simon Bünzli]

Attachment: trivial fix (only code shuffling)

Looks like with quit-application-granted being dispatched later than with Firefox 2.0, we now close the last window first in the shutdown case and run into a bug we've been having since the beginning but hasn't been noticeable so far.

The problem is that we discard the text cache in sss_onClose through sss_onTabRemove before we gather all possible data for the last time. Correcting the order of instructions trivially fixes this issue.

BTW: In the restart case, there are two quit-application-granted notifications - and the first one once again manages to hide the bug...

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Data loss is bad. Blocking for beta. :)

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 301191 [details] [diff] [review]
trivial fix (only code shuffling)

r=me thanks!

Comment 4

[Dietrich Ayala (:dietrich)]

Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.94; previous revision: 1.93
done

Comment 5

[Reed Loden [:reed]]

Comment on attachment 301191 [details] [diff] [review]
trivial fix (only code shuffling)

This landed without approval.

Comment 6

[Dietrich Ayala (:dietrich)]

Oops, sorry. Mconnor asked me to land it over IM.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 301191 [details] [diff] [review]
trivial fix (only code shuffling)

a=beltzner, post-hoc

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3 ID:2008020511