415487 - nsStringBuffer leak when closing Firefox with Software Installation Window open

Status: RESOLVED INCOMPLETE

(Core :: General, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: leak log

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008020319
Minefield/3.0b3pre

Steps to reproduce:
-> Save a Extension xpi on your Desktop (in my testcase i used the Flagfox Extension https://addons.mozilla.org/en-US/firefox/addon/5791
-> Open the Firefox Add-on Manager and drag and drop the xpi into the Extension Manager Window
-> The Software Installation Dialog comes up
-> Close Firefox
--> Leak

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Looks similar to bug 414671 and bug 414482. Lets retest once those are landed.

Comment 2

[Carsten Book [:Tomcat]]

Attachment: new leak log

still leaks after the other patches landed on  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008020717 Firefox/3.0b4pre:

nsStringStats
 => mAllocCount:          62470
 => mReallocCount:         8801
 => mFreeCount:           62465  --  LEAKED 5 !!!
 => mShareCount:          53682
 => mAdoptCount:           5293
 => mAdoptFreeCount:       5293

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This doesn't sound like it will happen too often so marking non-blocking. That said, there seems to be a generic problem somewhere of leaks nsStringBuffers, so it might get fixed when we fix that. Tracked in bug 416175.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I can reproduce this one!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Ugh, now I can't.

Comment 6

[Jesse Ruderman]

If I follow these steps on Mac (using Cmd+Q for "close Firefox"), Firefox fails to quit, but doesn't leak.