415544 - Mass-change erases all values from custom multi-select fields

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

I don't know what regressed it, but doing a mass-change deletes all values already set to multi-select fields, even with --do_not_change--.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

$cgi->param('defined_foo') must be deleted if $cgi->param('foo') eq '--do_not_change--' else process_bug.cgi sees that as a wish to clear the 'foo' field.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 301373 [details] [diff] [review]
patch, v1

>+        # Ignore defined_$name if param($name) eq dontchange.
>+        next if !defined $cgi->param($name);

  Wait, that doesn't seem to do what the comment above states...?

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
>   Wait, that doesn't seem to do what the comment above states...?

It does. When cf_<multi_select_name> eq 'dontchange', we delete defined_cf_<multi_select_name> else we are going to erase everything. So when we encounter defined_cf_<multi_select_name> in the foreach loop (foreach my $name ($cgi->param)), we have to skip it as it has already been deleted, and so $cgi->param('defined_cf_<multi_select_name>') is undefined. Else we get an error about an uninitialized value when doing the 'eq' comparison.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 301373 [details] [diff] [review]
patch, v1

Ah, I get it now.

On checkin, change the comment to:

# Skip ones we've already deleted (such as "defined_$name").

Comment 5

[Frédéric Buclin]

I fixed the comment on checkin:

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.404; previous revision: 1.403
done