415736 - delete/detach attachments in background without question for user

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Lukas Durfina]

User-Agent:       Opera/9.23 (Windows NT 5.1; U; en)
Build Identifier: version 2.0.0.9 (20071031)

I will appreciate adding a possibility to detach/delete attachment(s) without question for user as it is acctually, when I use messenger.detachAllAttachments(...) or messenger.detachAttachment(...).
I am developing virus-checking extension, and this possibility will be usefull.
And there is at least one next extension, where it will be applicable.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Magnus Melin [:mkmelin]]

Got a patch for that;) ?

Comment 2

[Lukas Durfina]

I hope, that you will think out something, because
I dont have experience with writing code to mozilla.
If I am not wrong, problem is calling of function
PromptIfDeleteAttachments(...). 
I have two ideas: make new function, where PromptIfDeleteAttachments() 
wont be called, but that will duplicate code, so I suppose, you will
refuse it. Or add the default argument to these functions, for example
DetachAllAttachments(PRUint32 aCount,
                     const char ** aContentTypeArray,
                     const char ** aUrlArray,
                     const char ** aDisplayNameArray,
                     const char ** aMessageUriArray,
                     PRBool aSaveFirst,
                     PRBool aInBackground = false);

I think the second idea is fine. Is it acceptable?
If yes, I can try to make patch.

Comment 3

[Magnus Melin [:mkmelin]]

Sounds ok to me. Though use PR_FALSE instead of false.

Comment 4

[Lukas Durfina]

Attachment: patch

I hope it will be OK, it is patch for CVS version.

Comment 5

[Lukas Durfina]

I am sorry, I forgot patch for IDL file.
But I dont know how to add default parameters
in it. Can you help me?

Comment 6

[Magnus Melin [:mkmelin]]

IDL files use something like 
 [optional] in boolean 

Also remember to change the uuid for it.

Comment 7

[Lukas Durfina]

Attachment: patch for idl file

Comment 8

[Magnus Melin [:mkmelin]]

Please attach the diffs all in one file, then request r/sr - bienvenu might be the most suitable reviewer in this case. 
See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

Comment 9

[Lukas Durfina]

Attachment: complete patch for deleting attachments in background

Comment 10

[David :Bienvenu]

Lukas, can you change the inBackground name to something more descriptive, like withoutWarning? Also

>   if (!inBackground)
>     if (NS_FAILED(PromptIfDeleteAttachments(saveFileUris != nsnull, aCount, aDisplayNameArray)))

should be just one if statement,

if (!withoutWarning && NS_FAILED(PromptIfDeleteAttachments(saveFileUris != nsnull, aCount, aDisplayNameArray)))
  return NS_OK;

Comment 11

[Lukas Durfina]

Attachment: new patch

Thanks for reply,
I hope, it will be ok.

Comment 12

[Lukas Durfina]

Attachment: hopefully last one patch

I am sorry, I forget update before diff

Comment 13

[David :Bienvenu]

Comment on attachment 304812 [details] [diff] [review]
hopefully last one patch

looks good, thx, Lukas.

Comment 14

[Reed Loden [:reed]]

Checking in mailnews/base/public/nsIMessenger.idl;
/cvsroot/mozilla/mailnews/base/public/nsIMessenger.idl,v  <--  nsIMessenger.idl
new revision: 1.74; previous revision: 1.73
done
Checking in mailnews/base/src/nsMessenger.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMessenger.cpp,v  <--  nsMessenger.cpp
new revision: 1.381; previous revision: 1.380
done
Checking in mailnews/base/src/nsMessenger.h;
/cvsroot/mozilla/mailnews/base/src/nsMessenger.h,v  <--  nsMessenger.h
new revision: 1.48; previous revision: 1.47
done