415747 - coordinates for syntax errors incorrect/incomplete

Status: RESOLVED FIXED

(Tamarin Graveyard :: Self-hosting compiler (ESC), defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Util::internalError doesn't pass on its |file| or |line| params (and actually passes |msg| as |file|).  column coordinates aren't passed at all.

I'm attaching a patch that fixes most of this.  However, please note:

* I think an off-by-1 error remains in the column coord, but replacing all assignments of colCoord to 0 with 1 didn't seem to fix it, and I don't care enough to dig further (nor to argue if column zero exists :)

* We assign a 'column' attribute to the SyntaxError, but I'm not sure if there is a precedent for a different name (ie, does ASC set such an attribute?)

* cogen.es still passes 0 as the column number - I can't see where that is tracked.  I'm not sure if this is a problem in practice.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: fix coords for syntax errors

Comment 2

[Lars T Hansen]

I'm about to land a major rewrite of the entire front end, so this patch has limited applicability.  Line number tracking has changed, and I'm doing away with column coordinates completely.

I'd prefer if we discard the present patch so that it doesn't create needless merge trouble for me.  But we can keep the bug open and I'll mine the patch for insight when I get ready to ship the rewrite.

The rewrite should be ready thursday/friday of this week but may come as late as next week (meetings, travel).

Comment 3

[Lars T Hansen]

A similar but not equivalent fix has been posted as part of the cleanup in bug 416454.

Comment 4

[Lars T Hansen]

Pushed as 378:e5dc4ee7b1ff

Comment 5

[Lars T Hansen]

Comment on attachment 301465 [details] [diff] [review]
fix coords for syntax errors

Superseded by other fix.