Closed Bug 415750 Opened 13 years ago Closed 13 years ago

Download notification in status bar using wrong icon size

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta4

People

(Reporter: micmon, Assigned: reed)

References

Details

Attachments

(2 files, 2 obsolete files)

The download notification in the status bar uses the 32x32 download icon which is also used for the notification popup. Scaling the 32x32 causes the icon to appear very blurry. Please use the 16x16 icon instead (part of Toolbar-small.png).
Attached image Screenshot
This shows the blurred icon and also how the 16x16 icon will look like.
Attached patch patch - v1 (obsolete) — Splinter Review
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #301509 - Flags: review?(rflint)
Attached patch patch - v2 (obsolete) — Splinter Review
Be nice and fix everybody.
Attachment #301509 - Attachment is obsolete: true
Attachment #301510 - Flags: review?(rflint)
Attachment #301509 - Flags: review?(rflint)
OS: Linux → All
Hardware: PC → All
Blocks: 402278
Comment on attachment 301510 [details] [diff] [review]
patch - v2

>--- browser/themes/pinstripe/browser/browser.css	4 Feb 2008 19:37:26 -0000	1.121
>+++ browser/themes/pinstripe/browser/browser.css	5 Feb 2008 16:45:35 -0000
>@@ -1472,20 +1472,16 @@ toolbarbutton.bookmark-item[dragover="tr
> #identity-popup-container {
>     background-image: none;
>     background-color: white;
>     min-width: 280px;
>     padding: 10px;
> }
> 
> #download-monitor {
>-  list-style-image: url("chrome://mozapps/skin/downloads/downloadStatusIcon.png");
>-}
Don't change this icon. It's already 16x16 and different from the one in the toolbar.
>-
>-#download-monitor image {
>-  height: 16px;
>-  width: 16px;
But feel free to get rid of this.
>+  list-style-image: url("chrome://browser/skin/Toolbar-small.png");
>+  -moz-image-region: rect(0px, 96px, 16px, 80px); 
> }

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/downloads/downloadStatusIcon.png
http://mxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/Toolbar-small.png
Attachment #301510 - Flags: review-
Attached patch patch - v3Splinter Review
Attachment #301510 - Attachment is obsolete: true
Attachment #301528 - Flags: review?(mano)
Attachment #301510 - Flags: review?(rflint)
Comment on attachment 301528 [details] [diff] [review]
patch - v3

Don't use a large icon when a smaller one should be used.
Attachment #301528 - Flags: approval1.9?
Attachment #301528 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.176; previous revision: 1.175
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.123; previous revision: 1.122
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.170; previous revision: 1.169
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
You need to log in before you can comment on or make changes to this bug.