415750 - Download notification in status bar using wrong icon size

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

The download notification in the status bar uses the 32x32 download icon which is also used for the notification popup. Scaling the 32x32 causes the icon to appear very blurry. Please use the 16x16 icon instead (part of Toolbar-small.png).

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot

This shows the blurred icon and also how the 16x16 icon will look like.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v2

Be nice and fix everybody.

Comment 4

[Ed Lee :Mardak]

Comment on attachment 301510 [details] [diff] [review]
patch - v2

>--- browser/themes/pinstripe/browser/browser.css	4 Feb 2008 19:37:26 -0000	1.121
>+++ browser/themes/pinstripe/browser/browser.css	5 Feb 2008 16:45:35 -0000
>@@ -1472,20 +1472,16 @@ toolbarbutton.bookmark-item[dragover="tr
> #identity-popup-container {
>     background-image: none;
>     background-color: white;
>     min-width: 280px;
>     padding: 10px;
> }
> 
> #download-monitor {
>-  list-style-image: url("chrome://mozapps/skin/downloads/downloadStatusIcon.png");
>-}
Don't change this icon. It's already 16x16 and different from the one in the toolbar.
>-
>-#download-monitor image {
>-  height: 16px;
>-  width: 16px;
But feel free to get rid of this.
>+  list-style-image: url("chrome://browser/skin/Toolbar-small.png");
>+  -moz-image-region: rect(0px, 96px, 16px, 80px); 
> }

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/downloads/downloadStatusIcon.png
http://mxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/Toolbar-small.png

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v3

Comment 6

[Asaf Romano (gone)]

Comment on attachment 301528 [details] [diff] [review]
patch - v3

r=mano

Comment 7

[Reed Loden [:reed]]

Comment on attachment 301528 [details] [diff] [review]
patch - v3

Don't use a large icon when a smaller one should be used.

Comment 8

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.176; previous revision: 1.175
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.123; previous revision: 1.122
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.170; previous revision: 1.169
done