If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Binary files always show up as Keep original and Fuzzy, whether have changed or not

RESOLVED FIXED

Status

Mozilla Localizations Graveyard
MozillaTranslator
--
enhancement
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: rickiees, Assigned: rickiees)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 301729 [details] [diff] [review]
Patch to add MD5 hashes and comparisons to binary files

Binary files (namely, images) always show up in the list of updated "strings", and they get their Keep original and Fuzzy flags set to True.

Instead this behaviour, MozillaTranslator should include a binary file in the list of changes only if the binary content has actually changed, and should honor the Keep original flag.

I intend to do this using an MD5 hash saved as a property of binary files. Computing the MD5 doesn't really impact performance, since it is done only on updating (JAR and CVS modes) and the image files are fairly small.
(Assignee)

Comment 1

10 years ago
The patch has been committed to CVS @ sf.net and will be published as part of MT v5.23.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 years ago
MT v5.23 has been released.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: Mozilla Localizations → Mozilla Localizations Graveyard
You need to log in before you can comment on or make changes to this bug.