416022 - Focus Find bar text box after toggling Match case with a key binding

Status: NEW

(Toolkit :: Find Toolbar, defect, P5)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020613 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008020613 Minefield/3.0b4pre

Right now, after toggling Match case with a key binding, it is focused, which makes the user focus the text box again to edit the search.

This does not make any sense, since once you have toggled Match case, you don't have much else to do with it, it makes more sense to focus the text box.

Reproducible: Always

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Seems like a nice to have and all, but does that mess with screen readers?

Comment 3

[Andrés Delfino]

(In reply to comment #2)
> Seems like a nice to have and all, but does that mess with screen readers?
> 

No idea :/

Comment 4

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

I don't like too much this idea... let the focus jumping in this way cold be a bit confusing.

Comment 5

[Mats Palmgren (inactive)]

I think the problem here is that we give the checkbox focus in the first
place.  For a checkbox inside a toolbar, accesskey should activate but
not focus (similar to <toolbarbutton>).
Compare the "Highlight all" button, which also toggles.

This has the advantage of not messing with the caret position and selection
of the text input at all and you can still TAB to the checkbox and activate
it using SPACE and it will stay focused.

Comment 6

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 7

[Lucas Malor (mail: c6kfnkn2uc AT snkmail DOT c0m)]

(In reply to comment #5)
> accesskey should activate but not focus [...] This has the advantage of not 
> messing with the caret position and selection of the text input at all and you 
> can still TAB to the checkbox and activate it using SPACE and it will stay 
> focused.

I agree, this is the ideal solution.

Comment 8

[Neil Deakin]

Comment on attachment 325181 [details] [diff] [review]
Patch rev. 1

I don't like this hard-coded binding url. I think it would be better here to add display="xul:toolbar" to the findbar and use ResolveTag to check for toolbars. (And add toolbar to the whitelist in nsXBLService::CheckTagNameWhiteList)

Why check specifically just for checkboxes?

Minusing for now.