Closed Bug 416032 Opened 12 years ago Closed 12 years ago
Minotaur is not detecting changes to search parameters
Minotaur is not detecting search parameters properly. It does not detect changes to: * search engine description * search engine icon * search suggestion URL * search form URL We need to ensure this data is outputted into our baselines and compared during our verifications.
Attachment #301793 - Flags: review?(l10n)
This is an output file showing all the information that is now exported. Also note that I removed the extension export for Dom Inspector and the Firefox theme. This was requested by both partner builds and l10n as version changes on these extensions would cause false failures.
Assignee: nobody → ctalbert
Status: NEW → ASSIGNED
This is a comparison run with a Finnish locale comparing Firefox Beta 3 with Beta 2. You can check this with the expected changes from source here: http://l10n.mozilla.org/~axel/HEAD-2008-02-06-14-00.html
Comment on attachment 301793 [details] [diff] [review] Patch to implement the search change detection I think we should group the output by engine, not by property. Separating the data is going to make the review of the reference files just harder. And I had to scan back and forth in the diff to see that the suggest diff for wikipedia was actually cut off from the rest by the google suggest diff. Regarding the diff for Finnish, that is the wrong way around. From a coverage perspective, this looks ok. hu looks like an interesting target to look at the bookmarks data, http://l10n.mozilla.org/~axel/HEAD-2008-02-06-14-00.html#hu, too.
Attachment #301793 - Flags: review?(l10n) → review-
This is the revised patch that lists all search engine attributes together in one block to make for easier to read diffs. Diff's that are more like Axel's code inspection diff's.
Comment on attachment 301969 [details] [diff] [review] The new patch that organizes all search engine attributes together r=me, with comments. I think we could just use engine.searchForm instead of engine.getSubmission("", null) but that's not that much of a matter to me. r=me either way.
Attachment #301969 - Flags: review?(l10n) → review+
This is exactly the same except that it uses engine.searchForm instead of engine.getSubmission('', null). I looked at how the actual search bar is implemented and it seems to be a better idea to use engine.searchForm in case we someday decide to change the default behavior of blank search queries. Carrying Axel's review forward.
Fix checked in on Trunk --> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Mass moving Minotaur bugs to Testing : Minotaur. Filter on MinotaurMassMove to ignore.
Component: Testing → Minotaur
Product: Core → Testing
QA Contact: testing → minotaur
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.