416072 - Should we vertically/horizontally center small preview images?

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Should we vertically/horizontally center small preview images?

Load https://remora-reskin.stage.mozilla.com/en-US/firefox/search?status=4&q=options+toolbar&cat=all, and look at the "Options toolbar button" preview image graphic.

It's oriented from the top-left, but is so small--at a meager 33x30, when the rest are ~200x150--that I think it'd look better vertically and horizontally centered.

Thoughts?

Comment 1

[Michael Morgan [:morgamic]]

Nah.  I don't think it's a big deal.  People with small icons will have to cope.  ;)

Comment 2

[Thomas]

There are other case's where the scaling looks really bad eg the image on this page just looks wrong and buggy. (700x79) -> to 200x150
Will probably affect most of the tool bar add-ons: eg.
https://preview.addons.mozilla.org/en-US/firefox/addon/6203 
or
https://preview.addons.mozilla.org/en-US/firefox/addon/5120
for just 2 examples

Comment 3

[Michael Morgan [:morgamic]]

I think this is something we should handle in the dev cp when people choose a highlight.  Moving to 3.4 for now, though.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> I think this is something we should handle in the dev cp when people choose a
> highlight.  Moving to 3.4 for now, though.
> 

(In reply to comment #2)
> There are other case's where the scaling looks really bad eg the image on this
> page just looks wrong and buggy. (700x79) -> to 200x150
> Will probably affect most of the tool bar add-ons: eg.
> https://preview.addons.mozilla.org/en-US/firefox/addon/6203 
> or
> https://preview.addons.mozilla.org/en-US/firefox/addon/5120
> for just 2 examples

I believe that's bug 416081, actually.

Comment 5

[Michael Morgan [:morgamic]]

Don't plan on centering preview images.