Closed Bug 416074 Opened 15 years ago Closed 15 years ago

TestRunner attempts to log after closing the log

Categories

(Testing :: Mochitest, defect)

Product:
Testing
Component:
Mochitest
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

Details

Attachments

(1 file)

pass the magic close-the-file string last
1.17 KB, patch
sayrer
: review+
Details | Diff | Splinter Review 
TestRunner.runNextTest does:

 TestRunner.logger.log("SimpleTest FINISHED");
 TestRunner.logger.log("Passed: " + $("pass-count").innerHTML);
 TestRunner.logger.log("Failed: " + $("fail-count").innerHTML);
 TestRunner.logger.log("Todo:   " + $("todo-count").innerHTML);

and MozillaFileLogger.getLogCallback does
    if (data.indexOf("SimpleTest FINISH") >= 0) {
      MozillaFileLogger.close();
    }

So the second log fails and runNextTest bails.  AFAICT, this has been busted since early last year...
Attachment #301829 - Flags: review?(sayrer)
Comment on attachment 301829 [details] [diff] [review]
pass the magic close-the-file string last

Nice one from me. Thanks for fixing.
Attachment #301829 - Flags: review?(sayrer)
Attachment #301829 - Flags: review+
Attachment #301829 - Flags: approval1.9+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Mass move of the rest of the Mochitest bugs from Core:Testing to Testing:Mochitest. Filter on MochitestMassMove to ignore.
Component: Testing → Mochitest
Product: Core → Testing
QA Contact: testing → mochitest
You need to log in before you can comment on or make changes to this bug.