416081 - Shouldn't use and distort add-on icon as full-sized preview image

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

I don't think we should use the icon-sized image as the full-sized add-on preview image.

See URL/screenshot: https://remora-reskin.stage.mozilla.com/en-US/firefox/addon/4748

Comment 1

[Fred Wenzel [:wenzel]]

I don't think we put it there: If the add-on author uploaded the same pic there, this is INVALID.

However, we should not force a small image to be inflated to 200x150 in any case. Morgamic, can you remove the width and height attributed from the preview image there? To my knowledge, the CSS is set up so the page does not "jump around" on load because the structure does not rely on image sizes (anymore).

Comment 2

[Michael Morgan [:morgamic]]

Uhhh, this makes me scared, but I can do it.

Comment 3

[Michael Morgan [:morgamic]]

It still jumps without image sizes in there.  I'd prefer to just solve this with policy on preview upload...

Comment 4

[Fred Wenzel [:wenzel]]

If you mean "policy" as in "on upload, we're going to enforce (shrink / pad with transparency) 200x150px" then I'm all for it.

Asking people to pick the right size otherwise the site will look crappy may not be the right way though?

Comment 6

[Ryan Doherty (:rdoherty)]

I'm putting in a fixed width+height for the image container, so I don't think content will jump.

Comment 7

[Ryan Doherty (:rdoherty)]

Attachment: Fixes to not stretch screenshots in thumbnail area.

Changed css & html so the image isn't distorted and doesn't break layouts.

Comment 8

[Fred Wenzel [:wenzel]]

Comment on attachment 310792 [details] [diff] [review]
Fixes to not stretch screenshots in thumbnail area.

Looks good, r+. (I only reviewed the part of the patch that's related to this bug).

Comment 9

[Ryan Doherty (:rdoherty)]

Fixed in r11442.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/addon/4748