Closed
Bug 416098
Opened 16 years ago
Closed 16 years ago
Need for some extra strings
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: berend.cornelius09, Assigned: berend.cornelius09)
Details
(Keywords: late-l10n)
Attachments
(1 file, 2 obsolete files)
5.37 KB,
patch
|
Details | Diff | Splinter Review |
Because of the issues bug 327780 'Need to sort out what sort of toolbar UI to offer for Lightning' and bug 412739 '"Next Week" events in Today pane are really "Soon" events'. We need some extra strings that are included within the patch attached.
Flags: blocking-calendar0.8?
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
Attachment #301862 -
Flags: review?
Comment 3•16 years ago
|
||
Comment on attachment 301862 [details] [diff] [review] patch with the localized Strings >-<!ENTITY calendar.nextweek.button.label "Next Week"> >+<!ENTITY calendar.nextweek.button.label "Soon"> You have to change the name of the entity!
Comment 4•16 years ago
|
||
-<!ENTITY calendar.nextweek.button.label "Next Week"> +<!ENTITY calendar.nextweek.button.label "Soon"> As already said in Bug 412739 you can't do this. L10n teams won't pick up the change because the entity name doesn't change. This way you fix it only for en-US but not for other translations. As you already add more entities why not just add a new entity like "calendar.soon.button.label"? In addition I would keep "calendar.nextweek.button.label" as it will be required in the future from my understanding of the Agenda improvement plans.
Comment 5•16 years ago
|
||
Comment on attachment 301862 [details] [diff] [review] patch with the localized Strings minussing based on the previous comments from ssitter and mschroeder. Please change the entity name if you change the meaning of the string. I suggest to use <!ENTITY calendar.soon.button.label
Attachment #301862 -
Flags: review? → review-
Updated•16 years ago
|
Attachment #301861 -
Attachment is obsolete: true
Attachment #301861 -
Flags: review?
Comment 6•16 years ago
|
||
Everyone who is watching this mail address. We will need to add three additional strings for 0.8. Sorry for the hassle.
Assignee | ||
Comment 7•16 years ago
|
||
Sorry my fault. I should have read Stefan's comment more carefully.
Attachment #301862 -
Attachment is obsolete: true
Attachment #301873 -
Flags: review?(bugzilla)
Updated•16 years ago
|
Flags: blocking-calendar0.8? → blocking-calendar0.8+
Target Milestone: Future → 0.8
Assignee | ||
Comment 8•16 years ago
|
||
patch checked in on trunk and MOZILLA_1_8_BRANCH => FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 9•16 years ago
|
||
This patch has been checked in as part of the patch for bug 413474 instead of this one. I would appreciate if we don't mix things up like that, please keep the patches separate.
Comment 10•16 years ago
|
||
Checked in latest nightly build 2008020719 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
Comment 11•16 years ago
|
||
Comment on attachment 301873 [details] [diff] [review] patch v. #2 I guess this review request is obsolete because the patch was already checked in.
Attachment #301873 -
Flags: review?(bugzilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•