Need for some extra strings

VERIFIED FIXED in 0.8

Status

Calendar
Calendar Views
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Berend Cornelius, Assigned: Berend Cornelius)

Tracking

({late-l10n})

unspecified
late-l10n
Bug Flags:
blocking-calendar0.8 +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
Because of the issues bug 327780 'Need to sort out what sort of toolbar UI to offer for Lightning' and bug 412739 '"Next Week" events in Today pane are really "Soon" events'. We need some extra strings that are included within the patch attached.
Flags: blocking-calendar0.8?
(Assignee)

Comment 1

10 years ago
Created attachment 301861 [details] [diff] [review]
patch with the localized Strings
Assignee: nobody → Berend.Cornelius
Status: NEW → ASSIGNED
Attachment #301861 - Flags: review?
(Assignee)

Comment 2

10 years ago
Created attachment 301862 [details] [diff] [review]
patch with the localized Strings
Attachment #301862 - Flags: review?
Comment on attachment 301862 [details] [diff] [review]
patch with the localized Strings

>-<!ENTITY calendar.nextweek.button.label       "Next Week">
>+<!ENTITY calendar.nextweek.button.label       "Soon">

You have to change the name of the entity!
-<!ENTITY calendar.nextweek.button.label       "Next Week">
+<!ENTITY calendar.nextweek.button.label       "Soon">

As already said in Bug 412739 you can't do this. L10n teams won't pick up the change because the entity name doesn't change. This way you fix it only for en-US but not for other translations.

As you already add more entities why not just add a new entity like "calendar.soon.button.label"? In addition I would keep "calendar.nextweek.button.label" as it will be required in the future from my understanding of the Agenda improvement plans.

Comment 5

10 years ago
Comment on attachment 301862 [details] [diff] [review]
patch with the localized Strings

minussing based on the previous comments from ssitter and mschroeder. Please change the entity name if you change the meaning of the string.

I suggest to use <!ENTITY calendar.soon.button.label
Attachment #301862 - Flags: review? → review-

Updated

10 years ago
Attachment #301861 - Attachment is obsolete: true
Attachment #301861 - Flags: review?

Comment 6

10 years ago
Everyone who is watching this mail address. We will need to add three additional strings for 0.8. Sorry for the hassle.
(Assignee)

Comment 7

10 years ago
Created attachment 301873 [details] [diff] [review]
patch v. #2

Sorry my fault. I should have read Stefan's comment more carefully.
Attachment #301862 - Attachment is obsolete: true
Attachment #301873 - Flags: review?(bugzilla)

Updated

10 years ago
Flags: blocking-calendar0.8? → blocking-calendar0.8+
Target Milestone: Future → 0.8
(Assignee)

Comment 8

10 years ago
patch checked in on trunk and MOZILLA_1_8_BRANCH

=> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
This patch has been checked in as part of the patch for bug 413474 instead of this one. I would appreciate if we don't mix things up like that, please keep the patches separate.

Comment 10

10 years ago
Checked in latest nightly build 2008020719 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
Comment on attachment 301873 [details] [diff] [review]
patch v. #2

I guess this review request is obsolete because the patch was already checked in.
Attachment #301873 - Flags: review?(bugzilla)
You need to log in before you can comment on or make changes to this bug.