41614 - Rename and move "Search Options" menu item

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P2)

Description

[johng]

The Search menu currently includes a "Search Options" item, but the text needs 
to be changed and the placement within the menu needs to be changed.

*Naming*

Rename the menu item from "Search Options" to:
My Sidebar Search Tab

And rename the sub-menu options from "simple" and "advanced" to:
Basic
Advanced

*Placement within menu*

In general, it should be moved to the bottom or almost the bottom of the menu 
and be set apart with a separator line.

More specifically, a separator line should be placed just above this menu item. 
 In the mozilla build, this menu item should be the very last item in the Search 
menu.  In the Netscape branded build, it should be the second to last item, just 
before the "Internet Keywords" item (no separator line between these two, just 
one above the first one).

*Additional notes*

When you pull "Search Options" out of the higher location in the search menu 
where it is now, you should also remove the separator line that comes with it.  
The end result is to have no separator lines between the following search menu 
items: "Search the Web", "Search Bookmarks/History", "Search Mail", "Search 
Address Book".

Also note that the "Internet Keywords" item will probably be renamed to "Using 
Search and Keywords" and will link to online help.  Verah is assigning a 
separate bug for this item.

Comment 1

[johng]

Because of the usability concerns we have with this menu item (which was our 
compromise in a mtg with Jim Martin), we want to get feedback during PR2.  It is 
also a very easy, low risk fix.

Therefore nominating for nsbeta2 and marking M17.

Comment 2

[don]

Yep, I think we need to do this.  Ben, how hard is it to do all this?

Comment 3

[Phil Peterson]

[nsbeta2+] exception feature part of compromise with Netcenter.

Comment 4

[Blake Ross]

I can do this right now

Comment 5

[Blake Ross]

Attachment: patch (for mozilla)

Comment 6

[Blake Ross]

Attachment: patch part 2

Comment 7

[Blake Ross]

Oops..  Sorry, just noticed two [minor] problems with my patches:

* the first patch for navigatorOverlay.xul also contains the tiny patch for 
bug 37537, which had been in my tree at the time.

* the second patch for navigator.dtd changes the build ID to 2000060908

Once these are reviewed, I'll resubmit the patches if you wish.  I guess the 
patch for 37537 can just be reviewed and checked in along with this one, but 
I'll fix the build ID one after review.

Comment 8

[Blake Ross]

sigh. sorry folks, I also just noticed that the patch moves "Search the Web" 
below "Search Addressbook", instead of leaving it above "Search 
Bookmarks/History" as it should have been.  I'm _really_ not this dumb, this is 
just further proof that 3:45 AM is not the time to be making patches.

I'll attach some much better patches tomorrow...for now, let me know if these 
satisfy the general idea of what you wanted ('xcept for what i just mentioned)

Comment 9

[Blake Ross]

Attachment: good navigatorOverlay.xul patch (for mozilla) - ignore the old "patch (for mozilla)"

Comment 10

[Blake Ross]

sorry about all the spam from this, everyone.  patches are now fine...ignore 
the "patch (for mozilla)" and use the second and third patches.

john - you didn't specify which accelerator key you want "My Sidebar Search 
Tab" to use, however.

Comment 11

[Blake Ross]

fixed checked in

Comment 12

[Blake Ross]

ben changed this to "My Sidebar Search Panel" (rather than "tab"), presumably 
for a good reason...other than that, though, this looks fixed to me..

Comment 13

[verah (gone)]

It should be "My Sidebar Search Tab" -- these thingys are tabs, not panels. 
John, do you want to reopen for this? Or should we call it "UI text polish" and 
fix it next time?

Comment 14

[Blake Ross]

I agree that it should be tab...that's how they're referred to throughout the 
rest of the app. ben, why'd you change it?

Comment 15

[Blake Ross]

Ben wrote and explained why he made the change to "panels" instead of "tabs", 
and his reasoning makes a lot of sense -- the different components of the 
sidebar might not resemble tabs at all in other skins, despite their appearance 
in the modern skin.  He also explained that there are better things in store 
for the sidebar after the 6.0 release, and we shouldn't limit ourselves to 
calling them tabs because of this ("panels" is much more general).

in any case, can we verify this please?

Comment 16

[Claudius Gayle]

johng I'd ask that you take a quick glance at this to be sure but based on your original writeup and what I
can verify in the builds I'd say this was fixed. The only thing I'm not 100% on is the position of the
My Sidebar Search Panel menuitem within the menu and the use of separators around it.

I'm presuming these are correct and marking VERIFIED(2000062308). If they are not, feel free to reopen.