416177 - gnomestripe: current tab text should not be bold

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b4pre) Gecko/2008020704 Fedora/8 (Werewolf) Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b4pre) Gecko/2008020704 Fedora/8 (Werewolf) Minefield/3.0b4pre

current behavior is wrong, not like the native apps does.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Actual Results:  
bold text on current tab

Expected Results:  
text not bold on current tab

Comment 1

[u294409]

.tabbrowser-tab[selected="true"] {
  margin-bottom: 0px;
  font-weight: bold;
}

should be changed to

.tabbrowser-tab[selected="true"] {
  margin-bottom: 0px;
  font-weight: normal;
}

or better, "font-weight" should be removed, since GTK indicates in visually easy way what tab is currently selected.

ps: /chrome/classic.jar/skin/classic/browser/browser.css

Comment 2

[Andrés Delfino]

Jakub, please set version to Trunk.

Nominating as blocking since this differs with native application in one of the more prominent and visible areas of Fx: tabs.

Comment 3

[Andrés Delfino]

I can confirm with:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008031103 Minefield/3.0b5pre

Comment 4

[u294409]

Changed version, as requested :) .

Comment 5

[Ian Spence]

Attachment: Removes the CSS that makes text bold on the selected tab

Was hoping this could be one of the bugs that got Jakub into making patches, but alas.  Fix is simple and allows me to remove a line from my userChrome.css file

Comment 6

[u294409]

Ian, paths in filesystem and in chrome:// are slightly different.

Creating patches is not hard work, however here I could have little problem (; .

Hopefully, some beautiful day I'll attach a patch (like in GNOME BZ) and probably notify you :P .

Comment 7

[Asaf Romano (gone)]

Comment on attachment 309079 [details] [diff] [review]
Removes the CSS that makes text bold on the selected tab

some ux-approval would be nice.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 309079 [details] [diff] [review]
Removes the CSS that makes text bold on the selected tab

I'm in favor of anything that helps make us more native, but this change does have a slight usability implication.  Switching ui-r to beltzner for his feedback.

Comment 9

[u294409]

Usability? Funny...

All GTK engines and themes draw current tab in different way than others, so Firefox shouldn't differ from native apps...

Comment 10

[Ian Spence]

Attachment: Shows how selected tabs look in various themes when the bold text is removed

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 309079 [details] [diff] [review]
Removes the CSS that makes text bold on the selected tab

uir+a=beltzner, yeah, this is OK

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/gnomestripe/browser/browser.css 	1.212