Open Bug 416193 Opened 16 years ago Updated 15 years ago

Use a url bar feed icon without dropmarker

Categories

(SeaMonkey :: Bookmarks & History, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: stefanh, Unassigned)

References

Details

Attachments

(3 files)

I think the current feed icon/button shouldn't have a dropmarker. Especially on mac, it looks a bit strange having 2 dropmarkers side-by-side (the other is the history dropmarker which is just a plain triangle on mac).

I've checked Firefox, Safari, Camino and Opera - none of them have a dropmarker on the url bar feed icon. Since the behaviour is similar in those browsers - click on the button/icon to display a list - I think users are aware of that we're dealing with a button here.
Blocks: 240393
I assume that we're going to use the icons with a dropmarker in the future, so I kept them. I'm going to let Justin have a look at this first.
Attachment #301970 - Flags: review?(bugspam.Callek)
Comment on attachment 301970 [details] [diff] [review]
Switch icon and add a tooltip

Justin, for the tooltip wording, you might want to look at bug 416180. That might be even better than my proposal here or act as an inspiration :)
Comment on attachment 301970 [details] [diff] [review]
Switch icon and add a tooltip

r+ on image change.

>+<!ENTITY feedsButton.tooltip          "Show list of available feeds">

I'm ok with this, though I do prefer "List feeds offered by this page" as Camino did.

I'm ok with any string Neil (or jag) is also ok with though, UI tooltips are not my strong suit.
Attachment #301970 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 301970 [details] [diff] [review]
Switch icon and add a tooltip

Please see comment #2 and comment #3 for the string change.
Attachment #301970 - Flags: superreview?(neil)
Although Callek decided not to initially implement it, my idea was to have it so that one feed would not have a dropdown or the arrow on the icon, but once you had two feeds on one page then you would get the arrow and the dropdown.
Attached image screenshot
Are there drop-downs on those icons in other browsers? I have just checked mac browsers. I'm not saying it's an argument against the drop-down (but it's a fact that should be considered), my main reason is that I think it looks a bit odd, at least on mac.
BTW, in the other bug they ended up using "List feeds offered by this page".

Also, in the Modern theme it doesn't look that bad on Mac because there's a bit of grey surrounding the history dropdown triangle. Perhaps the "native"(?) theme could do the same.

I like Neil's idea. KaiRo suggested that for the single feed case we could put the feed name as the tooltip, and when you click it it does whatever action a click on one of the menuitems would (which I think Neil's suggestion implied).
(In reply to comment #7)
> BTW, in the other bug they ended up using "List feeds offered by this page".
> 
> Also, in the Modern theme it doesn't look that bad on Mac because there's a bit
> of grey surrounding the history dropdown triangle. Perhaps the "native"(?)
> theme could do the same.

But you have to admit that it looks a "bit" odd ;-). Also, I think the current look of the history drop-down is the look we want. I guess I just feel that the feed icon doesn't need a drop-down because it looks odd and it's not necessary. If SeaMonkey was the first app that implemented feeds it might have been a different case, but now we're one of the last ones and then I think there's no reason to do this (visually) different than other apps.

> 
> I like Neil's idea. KaiRo suggested that for the single feed case we could put
> the feed name as the tooltip, and when you click it it does whatever action a
> click on one of the menuitems would (which I think Neil's suggestion implied).
> 

If an action is to be performed (subscribe etc), I think you would want the tooltip to inform users of that.
(In reply to comment #8)
>If an action is to be performed (subscribe etc), I think you would want the
>tooltip to inform users of that.
Yes, in that case the tooltip would be "Subscribe to %S".
Attachment #301970 - Flags: superreview?(neil) → superreview-
This is for Opera, I'll be attaching other Browsers in the near future.

(For what its worth, I do agree that getting rid of the dropdown here is a good thing, especially after seeing all these examples)
Assignee: stefanh → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: