41620 - Need charset override to complete bookmarks charset caching

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[[e-mail] (away - not reading bugmail)]

I'm functionally complete with bug 18022, have checked it all changes a last 
week.

However, since charset override is not turned on by default and might need
some finishing touches I was not able to enable proper usage of the feature.

We collect, cache and retrieve the charset information just fine, although I 
had to give this charset source a  priority lower than kCharsetFromUserDefault 
to give users a chance to override some potentially incorrect charsets.

Once charset override is on, we should increase the priority of the cached 
charset, which will result in speedier page loads and better user experience 
for all bookmarked sites.

I'm marking the dependence on 18022, to to increase chances of nsbeta2+ 
approval.

Please move kCharsetFromCache and kCharsetFromBookmarks up in the enum in 
nsIParser.h, they should be positioned between kCharsetFromAutoDetection and 
kCharsetFromMetaTag.

http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsIParser.h#84

Comment 1

[[e-mail] (away - not reading bugmail)]

need this feature to be enabled to close 18022, which has been marked nsbeta2+

Comment 2

[Phil Peterson]

[nsbeta2+] since required for an exception feature

Comment 3

[Blake Ross]

cata, didn't you check in the fix for this?

Comment 4

[cata]

Fixed. However, as we were shooting for minimal changes, some more cosmetic work 
should be done. It is described in bugs 43529 and 43530.

Comment 5

[Teruko Kobayashi]

I verified this in 2000-06-29-08 Mac and Win32 build.  I cannot lanch Netscape6 
in linux for a while.  I will verify this in linux next build.

Comment 6

[Teruko Kobayashi]

I verified this in 2000-06-30-08 Linux build.