Need charset override to complete bookmarks charset caching

VERIFIED FIXED in M17

Status

()

Core
Internationalization
P3
major
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: jbetak@netscape.com (away - not reading bugmail), Assigned: cata)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2+])

I'm functionally complete with bug 18022, have checked it all changes a last 
week.

However, since charset override is not turned on by default and might need
some finishing touches I was not able to enable proper usage of the feature.

We collect, cache and retrieve the charset information just fine, although I 
had to give this charset source a  priority lower than kCharsetFromUserDefault 
to give users a chance to override some potentially incorrect charsets.

Once charset override is on, we should increase the priority of the cached 
charset, which will result in speedier page loads and better user experience 
for all bookmarked sites.

I'm marking the dependence on 18022, to to increase chances of nsbeta2+ 
approval.

Please move kCharsetFromCache and kCharsetFromBookmarks up in the enum in 
nsIParser.h, they should be positioned between kCharsetFromAutoDetection and 
kCharsetFromMetaTag.

http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsIParser.h#84
need this feature to be enabled to close 18022, which has been marked nsbeta2+
Blocks: 18022
Keywords: nsbeta2

Comment 2

18 years ago
[nsbeta2+] since required for an exception feature
Whiteboard: [nsbeta2+]
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → M17

Comment 3

18 years ago
cata, didn't you check in the fix for this?
(Assignee)

Comment 4

18 years ago
Fixed. However, as we were shooting for minimal changes, some more cosmetic work 
should be done. It is described in bugs 43529 and 43530.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 5

18 years ago
I verified this in 2000-06-29-08 Mac and Win32 build.  I cannot lanch Netscape6 
in linux for a while.  I will verify this in linux next build.

Comment 6

18 years ago
I verified this in 2000-06-30-08 Linux build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.