416272 - SHOWFOR does not detect OS with other browsers

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

Using either IE or Safari, go to an article using the OS selector (e.g. <http://support.mozilla.com/kb/AUS+Update+XML+File+Malformed+200>). There is no OS selected, and all content is shown.

IE traffic makes up roughly 25% of sumo sessions.

Comment 1

[David Tenser [:djst]]

What is the default view when no OS is selected?

Comment 2

[Chris Ilias [:cilias]]

When no OS is selected, everything is shown.

"In the Location Bar, type https://addons.mozilla.org and press EnterReturn."

"Right-clickHold down the Ctrl key while you click..."

Comment 3

[David Tenser [:djst]]

Eww.. Nelson, can we default to Windows if no OS is detected?

Comment 4

[Nelson Ko [:nkoth]]

The problem is that navigator.oscpu does not work in those browsers.

I have made changes to default to windows/fx2 if no firefox is used.

Jason, do you know the detection method for Safari, or some other way? The relevant file is js/wikiplugin_showfor.js

Comment 5

[Jason Barnabe (np)]

http://www.quirksmode.org/js/detect.html

Comment 6

[David Tenser [:djst]]

Dupe of 413667 (or other way around)?

Comment 7

[Chris Ilias [:cilias]]

I don't think so. Bug 413667 is a Forums bug about browser detection when using <http://support.mozilla.com/tiki-view_forum.php?locale=en-US&forumId=1&openpost=1> (I think). This bug is about OS detection in SHOWFOR.

Comment 8

[E. Cooper [:ecooper]]

Can someone confirm this is still an issue?

Comment 9

[Chris Ilias [:cilias]]

This is still an issue on Safari/Mac.

Comment 10

[Chris Ilias [:cilias]]

WRM on IE8/Vista.

Comment 11

[Chris Ilias [:cilias]]

s/WRM/WFM :-)

Comment 12

[Chris Ilias [:cilias]]

This is also an issue with Safari and Chrome on Vista.

Comment 13

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

Thanks for the links and pointers. This works like a charm with Konqueror, Firefox, and IE 6 :)

Comment 14

[Laura Thomson :laura]

Comment on attachment 393081 [details] [diff] [review]
patch, v1

Why do we have a special case for iphones?

Comment 15

[Paul Craciunoiu [:paulc]]

Attachment: patch, v2

My bad. I sort of just skipped over it cause it was in the quirksmode script :)

Comment 16

[Paul Craciunoiu [:paulc]]

r49048 / r49049

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Bringing in the big guns (mozwebqa); I could use a lot of help testing this, guys :-)

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #17)
> Bringing in the big guns (mozwebqa); I could use a lot of help testing this,
> guys :-)

Testable here: http://support-stage.mozilla.org/en-US/kb/AUS+Update+XML+File+Malformed+200.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

OK, honestly, I tested with my iPhone and its version of Safari, and it selects "Windows"; bizarre.  (Cleared my cookies, so it's not from really unlikely previous iPhone testing.)

Don't know that we care enough to special-case it to even fix this, given comment 14, but I'll leave that up to others.

Vishal and I have tested the gamut of browers and it's looking good to us.

Comment 20

[Paul Craciunoiu [:paulc]]

The iPhone part was removed... So, that's why :)

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #20)
> The iPhone part was removed... So, that's why :)

Originally I thought you put it in "Just because (tm)", but I now realize you actually tested with it -- silly me :-)

Verified FIXED!